From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2F42C433E7 for ; Mon, 19 Oct 2020 18:36:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18DC32231B for ; Mon, 19 Oct 2020 18:36:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eHY7jNAJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18DC32231B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUa16-000089-GM for qemu-devel@archiver.kernel.org; Mon, 19 Oct 2020 14:36:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUZz3-0007g8-9O for qemu-devel@nongnu.org; Mon, 19 Oct 2020 14:34:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kUZz0-0005No-Of for qemu-devel@nongnu.org; Mon, 19 Oct 2020 14:34:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603132449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AAeTTkRe2cYvYHHbtBf/5Zm8X/GAbTwFl8pUfDkljvk=; b=eHY7jNAJZFbEFmaITe85HBhrx+ImVKwIGRuAZfYZnoKx/b7NnSJLA8/q3mwozRszh4i/Fc D0IFK4Fr7C9f3M0gfbsKHFRseQZcWvx1WUPw7YIosfgIxxwGHn4a3BuLUYyXveYMI4lnz4 66hHFcRjhUtkuFX4LWfeR+02vVIANbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-csPv1WU1MYCiWhl-U83tbQ-1; Mon, 19 Oct 2020 14:34:06 -0400 X-MC-Unique: csPv1WU1MYCiWhl-U83tbQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3FB4A8049C1 for ; Mon, 19 Oct 2020 18:34:04 +0000 (UTC) Received: from work-vm (ovpn-114-228.ams2.redhat.com [10.36.114.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1862160DA0; Mon, 19 Oct 2020 18:33:56 +0000 (UTC) Date: Mon, 19 Oct 2020 19:33:54 +0100 From: "Dr. David Alan Gilbert" To: Peter Xu Subject: Re: [PATCH] intel_iommu: Fix two misuse of "0x%u" prints Message-ID: <20201019183354.GH3565@work-vm> References: <20201019173922.100270-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201019173922.100270-1-peterx@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/19 02:32:01 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , qemu-devel@nongnu.org, "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Peter Xu (peterx@redhat.com) wrote: > Dave magically found this. Fix them with "0x%x". > > Reported-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > hw/i386/intel_iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index 749eb6ad63..70ac837733 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -2665,7 +2665,7 @@ static uint64_t vtd_mem_read(void *opaque, hwaddr addr, unsigned size) > > if (addr + size > DMAR_REG_SIZE) { > error_report_once("%s: MMIO over range: addr=0x%" PRIx64 > - " size=0x%u", __func__, addr, size); > + " size=0x%x", __func__, addr, size); > return (uint64_t)-1; > } > > @@ -2716,7 +2716,7 @@ static void vtd_mem_write(void *opaque, hwaddr addr, > > if (addr + size > DMAR_REG_SIZE) { > error_report_once("%s: MMIO over range: addr=0x%" PRIx64 > - " size=0x%u", __func__, addr, size); > + " size=0x%x", __func__, addr, size); > return; > } > > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK