* [PATCH] net: remove an assert call in eth_get_gso_type
@ 2020-10-20 8:11 P J P
2020-10-20 8:20 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: P J P @ 2020-10-20 8:11 UTC (permalink / raw)
To: Jason Wang; +Cc: Gaoning Pan, QEMU Developers, Prasad J Pandit
From: Prasad J Pandit <pjp@fedoraproject.org>
eth_get_gso_type() routine returns segmentation offload type to use
based on L3 protocol type. It calls g_assert_not_reached if L3
protocol is unknown, making the following return statement unreachable.
Remove the g_assert call, as it maybe triggered by a guest user.
Reported-by: Gaoning Pan <pgn@zju.edu.cn>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
net/eth.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index 0c1d413ee2..f36a418077 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -72,9 +72,6 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t l4proto)
}
}
- /* Unsupported offload */
- g_assert_not_reached();
-
return VIRTIO_NET_HDR_GSO_NONE | ecn_state;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: remove an assert call in eth_get_gso_type
2020-10-20 8:11 [PATCH] net: remove an assert call in eth_get_gso_type P J P
@ 2020-10-20 8:20 ` Philippe Mathieu-Daudé
2020-10-20 10:01 ` P J P
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-20 8:20 UTC (permalink / raw)
To: P J P, Jason Wang; +Cc: Gaoning Pan, QEMU Developers, Prasad J Pandit
On 10/20/20 10:11 AM, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> eth_get_gso_type() routine returns segmentation offload type to use
> based on L3 protocol type. It calls g_assert_not_reached if L3
> protocol is unknown, making the following return statement unreachable.
> Remove the g_assert call, as it maybe triggered by a guest user.
>
> Reported-by: Gaoning Pan <pgn@zju.edu.cn>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> ---
> net/eth.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index 0c1d413ee2..f36a418077 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -72,9 +72,6 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t l4proto)
> }
> }
>
> - /* Unsupported offload */
> - g_assert_not_reached();
Maybe LOG_UNIMP with useful fields, so when user send bug
report we directly know what has to be implemented.
> -
> return VIRTIO_NET_HDR_GSO_NONE | ecn_state;
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-20 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-20 8:11 [PATCH] net: remove an assert call in eth_get_gso_type P J P
2020-10-20 8:20 ` Philippe Mathieu-Daudé
2020-10-20 10:01 ` P J P
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).