qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "John Snow" <jsnow@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-block@nongnu.org
Subject: [PATCH 0/3] ide: fix SRST (again)
Date: Tue, 20 Oct 2020 16:02:39 -0400	[thread overview]
Message-ID: <20201020200242.1497705-1-jsnow@redhat.com> (raw)

My last fix for SRST wasn't entirely correct and caused a regression;
namely we need to mime execution of the diagnostic command. If we don't,
Linux bins the IDE device as 'horked'.

For detailed reading on the SRST protocol, I recommend checking out the
ATA8-APT specification.

John Snow (3):
  ide: run diagnostic after SRST
  ide: perform SRST as early as possible
  ide: clear SRST after SRST finishes

 hw/ide/core.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

-- 
2.26.2




             reply	other threads:[~2020-10-20 20:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 20:02 John Snow [this message]
2020-10-20 20:02 ` [PATCH 1/3] ide: run diagnostic after SRST John Snow
2020-10-20 20:02 ` [PATCH 2/3] ide: perform SRST as early as possible John Snow
2020-10-20 20:02 ` [PATCH 3/3] ide: clear SRST after SRST finishes John Snow
2020-10-21 20:03 ` [PATCH 0/3] ide: fix SRST (again) Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201020200242.1497705-1-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).