From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, tgolembi@redhat.com,
philmd@redhat.com, mdroth@linux.vnet.ibm.com
Subject: [PATCH 0/4] qga: Fix several guest-get-devices issues
Date: Wed, 21 Oct 2020 09:15:16 +0200 [thread overview]
Message-ID: <20201021071520.2168877-1-armbru@redhat.com> (raw)
To be frank, I'm disappointed the code passed review in this state.
There are excuses for each of the issues addressed in this series
(PATCH 1 naming is hard, PATCH 2 recognizing non-local relations is
hard, PATCH 3 mistakes on error paths are easy to miss, PATCH 4 can't
expect all reviewers to know "no more simple unions, please"). Still,
having so many of them escape notice is disappointing.
Please review.
Markus Armbruster (4):
qga: Rename guest-get-devices return member 'address' to 'id'
qga: Use common time encoding for guest-get-devices 'driver-date'
qga-win: Fix guest-get-devices error API violations
qga: Flatten simple union GuestDeviceId
qga/qapi-schema.json | 29 +++++++++++++++++++----------
qga/commands-win32.c | 39 ++++++++++++++++++++-------------------
2 files changed, 39 insertions(+), 29 deletions(-)
--
2.26.2
next reply other threads:[~2020-10-21 7:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 7:15 Markus Armbruster [this message]
2020-10-21 7:15 ` [PATCH 1/4] qga: Rename guest-get-devices return member 'address' to 'id' Markus Armbruster
2020-10-21 7:34 ` Philippe Mathieu-Daudé
2020-10-21 8:08 ` Markus Armbruster
2020-10-21 7:46 ` Marc-André Lureau
2020-10-21 7:15 ` [PATCH 2/4] qga: Use common time encoding for guest-get-devices 'driver-date' Markus Armbruster
2020-10-21 7:42 ` Marc-André Lureau
2020-10-21 7:15 ` [PATCH 3/4] qga-win: Fix guest-get-devices error API violations Markus Armbruster
2020-10-21 7:37 ` Marc-André Lureau
2020-10-21 7:39 ` Philippe Mathieu-Daudé
2020-10-21 7:15 ` [PATCH 4/4] qga: Flatten simple union GuestDeviceId Markus Armbruster
2020-10-21 7:35 ` Philippe Mathieu-Daudé
2020-10-21 7:36 ` Marc-André Lureau
2020-10-27 6:35 ` [PATCH 0/4] qga: Fix several guest-get-devices issues Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021071520.2168877-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tgolembi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).