From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7316C4363A for ; Wed, 21 Oct 2020 10:13:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16F16221FC for ; Wed, 21 Oct 2020 10:13:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XJnr5EUO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16F16221FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVB7C-0003HM-Uo for qemu-devel@archiver.kernel.org; Wed, 21 Oct 2020 06:13:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVB6U-0002nU-N9 for qemu-devel@nongnu.org; Wed, 21 Oct 2020 06:12:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:41297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kVB6R-0003bq-Jr for qemu-devel@nongnu.org; Wed, 21 Oct 2020 06:12:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603275138; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBs1yzgzkrbg+b93oYm4jK7K/TDPZ7fM2qzj1RGzh5M=; b=XJnr5EUO4UnZVt0S7zQM5xluKvX71p/LRDKEFQtXOSfTkYfYmB89BGgKXvaoXlwONFimb1 e7asvz/Ha+EAjMcxDvIJHy0xhzLnWhX2iHrEXs+r4EccqrxtcVG4whLKp5LUzStj3MjN/I HhQeo8mtky0rfje0rpPW3mGFAcgPM3A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-hlmyjOVTN5CAnGweEzmg0w-1; Wed, 21 Oct 2020 06:12:11 -0400 X-MC-Unique: hlmyjOVTN5CAnGweEzmg0w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F3D2387507A; Wed, 21 Oct 2020 10:12:09 +0000 (UTC) Received: from redhat.com (ovpn-114-86.ams2.redhat.com [10.36.114.86]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9043619D6C; Wed, 21 Oct 2020 10:12:06 +0000 (UTC) Date: Wed, 21 Oct 2020 11:12:03 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2 3/3] migration: stop returning errno from load_snapshot() Message-ID: <20201021101203.GH412988@redhat.com> References: <20201012122743.3390867-1-philmd@redhat.com> <20201012122743.3390867-4-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201012122743.3390867-4-philmd@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/20 22:12:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Kevin Wolf , Pavel Dovgalyuk , qemu-block@nongnu.org, Juan Quintela , qemu-devel@nongnu.org, Max Reitz , Pavel Dovgalyuk , Paolo Bonzini , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Oct 12, 2020 at 02:27:43PM +0200, Philippe Mathieu-Daudé wrote: > From: Daniel P. Berrangé > > None of the callers care about the errno value since there is a full > Error object populated. This gives consistency with save_snapshot() > which already just returns a boolean value. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Daniel P. Berrangé > [PMD: Return false/true instead of -1/0, document function] > Acked-by: Pavel Dovgalyuk > Signed-off-by: Philippe Mathieu-Daudé > --- > include/migration/snapshot.h | 9 ++++++++- > migration/savevm.c | 19 +++++++++---------- > monitor/hmp-cmds.c | 2 +- > replay/replay-snapshot.c | 2 +- > softmmu/vl.c | 2 +- > 5 files changed, 20 insertions(+), 14 deletions(-) > > diff --git a/include/migration/snapshot.h b/include/migration/snapshot.h > index a40c34307b5..9bc989a6b49 100644 > --- a/include/migration/snapshot.h > +++ b/include/migration/snapshot.h > @@ -23,6 +23,13 @@ > * On failure, store an error through @errp and return %false. > */ > bool save_snapshot(const char *name, Error **errp); > -int load_snapshot(const char *name, Error **errp); > +/** > + * save_snapshot: Load a snapshot. s/save/load/ > + * @name: path to snapshot Again, a name not a path. I'll apply this - * save_snapshot: Load a snapshot. - * @name: path to snapshot + * load_snapshot: Load an internal snapshot. + * @name: name of internal snapshot Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|