qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: thuth@redhat.com, david@redhat.com, cohuck@redhat.com,
	walling@linux.ibm.com, pasic@linux.ibm.com,
	borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
	mhartmay@linux.ibm.com
Subject: [PATCH 1/2] s390x: pv: Remove sclp boundary checks
Date: Wed, 21 Oct 2020 09:43:44 -0400	[thread overview]
Message-ID: <20201021134345.110173-2-frankja@linux.ibm.com> (raw)
In-Reply-To: <20201021134345.110173-1-frankja@linux.ibm.com>

The SCLP boundary cross check is done by the Ultravisor for a
protected guest, hence we don't need to do it. As QEMU doesn't get a
valid SCCB address in protected mode this is even problematic and can
lead to QEMU reporting a false boundary cross error.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Fixes: db13387ca0 ("s390/sclp: rework sclp boundary checks")
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
 hw/s390x/sclp.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
index 00f1e4648d..0cf2290826 100644
--- a/hw/s390x/sclp.c
+++ b/hw/s390x/sclp.c
@@ -285,11 +285,6 @@ int sclp_service_call_protected(CPUS390XState *env, uint64_t sccb,
         goto out_write;
     }
 
-    if (!sccb_verify_boundary(sccb, be16_to_cpu(work_sccb->h.length), code)) {
-        work_sccb->h.response_code = cpu_to_be16(SCLP_RC_SCCB_BOUNDARY_VIOLATION);
-        goto out_write;
-    }
-
     sclp_c->execute(sclp, work_sccb, code);
 out_write:
     s390_cpu_pv_mem_write(env_archcpu(env), 0, work_sccb,
-- 
2.25.1



  reply	other threads:[~2020-10-21 13:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 13:43 [PATCH 0/2] s390x: pv: Diag318 fixes Janosch Frank
2020-10-21 13:43 ` Janosch Frank [this message]
2020-10-21 14:12   ` [PATCH 1/2] s390x: pv: Remove sclp boundary checks David Hildenbrand
2020-10-21 15:48   ` Halil Pasic
2020-10-22  8:26   ` Thomas Huth
2020-10-21 13:43 ` [PATCH 2/2] s390x: pv: Fix diag318 PV fencing Janosch Frank
2020-10-21 14:14   ` David Hildenbrand
2020-10-21 14:18     ` Christian Borntraeger
2020-10-21 14:29       ` David Hildenbrand
2020-10-21 14:19     ` Janosch Frank
2020-10-21 14:21       ` David Hildenbrand
2020-10-22  8:23         ` [PATCH] " Janosch Frank
2020-10-22  8:32           ` David Hildenbrand
2020-10-22  8:39             ` Janosch Frank
2020-10-22  8:47               ` David Hildenbrand
2020-10-22  9:54           ` Halil Pasic
2020-10-22  9:55             ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201021134345.110173-2-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=mhartmay@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=walling@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).