qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: roms/efirom, tests/uefi-test-tools: update edk2's own submodules first
Date: Wed, 21 Oct 2020 14:30:15 +0200	[thread overview]
Message-ID: <20201021143015.3bd7faff.olaf@aepfle.de> (raw)
In-Reply-To: <46f7af9f-4a18-4352-dad2-cc176ed890e1@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

Am Wed, 21 Oct 2020 14:05:18 +0200
schrieb Laszlo Ersek <lersek@redhat.com>:

> Olaf: if you build QEMU from source, why don't you build SeaBIOS, iPXE,
> edk2 etc *also* from their corresponding pristine upstream clones /
> checkouts, using your own dedicated build scripts / packagings?

From my perspective it is like that:

I export xen/qemu/libivrt into an offline environment for building.
The "git clone/git export" is done without submodules, but each required submodule is of course cloned/exported as well into the target directory. In the end it is me who decides what is required or not, which means only a subset of all submodules need to be provided. The build process sees the complete source, and as a result nothing needs to be downloaded.

With current master there are these two offending git commands. In my environment they can not do anything but fail. I guess once the next qemu-X.Y release becomes available as the usual "qemu-X.Y.tar.xz" release these git commands will fail as well with 'make -C roms efirom'.

As said elsewhere, the correct approach might be to check what is missing and download only these submodules. This should take the existing configure knobs into account.


Olaf

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-10-21 12:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  9:16 roms/efirom, tests/uefi-test-tools: update edk2's own submodules first Olaf Hering
2020-10-20  9:29 ` Philippe Mathieu-Daudé
2020-10-20  9:35   ` Olaf Hering
2020-10-20  9:38   ` Philippe Mathieu-Daudé
2020-10-20  9:44   ` Daniel P. Berrangé
2020-10-20  9:54     ` Philippe Mathieu-Daudé
2020-10-21 12:05       ` Laszlo Ersek
2020-10-21 12:30         ` Olaf Hering [this message]
2020-10-21 13:28           ` Laszlo Ersek
2020-10-21 13:46         ` Daniel P. Berrangé
2020-10-21 17:27           ` Laszlo Ersek
2020-10-20 12:52 ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201021143015.3bd7faff.olaf@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=berrange@redhat.com \
    --cc=lersek@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).