From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E19DC4363A for ; Thu, 22 Oct 2020 09:10:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEA21223FB for ; Thu, 22 Oct 2020 09:10:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEA21223FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVWbk-0000kc-Na for qemu-devel@archiver.kernel.org; Thu, 22 Oct 2020 05:10:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVWaD-0007nl-7m for qemu-devel@nongnu.org; Thu, 22 Oct 2020 05:08:29 -0400 Received: from 9.mo52.mail-out.ovh.net ([87.98.180.222]:48017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVWaB-0004b5-7H for qemu-devel@nongnu.org; Thu, 22 Oct 2020 05:08:28 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.25]) by mo52.mail-out.ovh.net (Postfix) with ESMTPS id 0E6E11FFD00; Thu, 22 Oct 2020 11:08:24 +0200 (CEST) Received: from kaod.org (37.59.142.97) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 22 Oct 2020 11:08:23 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-97G002af0c1d17-838d-4a8c-bdb4-92943fadacab, 519BB44447FDA57395BBEBCDF0C34CC9BD4694BF) smtp.auth=groug@kaod.org Date: Thu, 22 Oct 2020 11:08:22 +0200 From: Greg Kurz To: Christian Schoenebeck Subject: Re: [PATCH v2 8/8] tests/9pfs: add local Tunlinkat hard link test Message-ID: <20201022110822.5bbd12cd@bahia.lan> In-Reply-To: <9bec33a7d8f006ef8f80517985d0d6ac48650d53.1603285620.git.qemu_oss@crudebyte.com> References: <9bec33a7d8f006ef8f80517985d0d6ac48650d53.1603285620.git.qemu_oss@crudebyte.com> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.97] X-ClientProxiedBy: DAG2EX2.mxp5.local (172.16.2.12) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: 38445582-6936-4b6a-a8fd-54a52ef129bb X-Ovh-Tracer-Id: 5478347473466661274 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrjeejgdduvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeertdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeefuddtieejjeevheekieeltefgleetkeetheettdeifeffvefhffelffdtfeeljeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddrleejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhg Received-SPF: pass client-ip=87.98.180.222; envelope-from=groug@kaod.org; helo=9.mo52.mail-out.ovh.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/22 05:08:24 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 21 Oct 2020 14:55:46 +0200 Christian Schoenebeck wrote: > This test case uses a Tunlinkat request to remove a previously hard > linked file by using the 9pfs 'local' fs driver. > > Signed-off-by: Christian Schoenebeck > --- Reviewed-by: Greg Kurz > tests/qtest/virtio-9p-test.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c > index 460fa49fe3..23433913bb 100644 > --- a/tests/qtest/virtio-9p-test.c > +++ b/tests/qtest/virtio-9p-test.c > @@ -1391,6 +1391,34 @@ static void fs_hardlink_file(void *obj, void *data, QGuestAllocator *t_alloc) > g_free(real_file); > } > > +static void fs_unlinkat_hardlink(void *obj, void *data, > + QGuestAllocator *t_alloc) > +{ > + QVirtio9P *v9p = obj; > + alloc = t_alloc; > + struct stat st_real, st_link; > + char *real_file = virtio_9p_test_path("08/real_file"); > + char *hardlink_file = virtio_9p_test_path("08/hardlink_file"); > + > + do_attach(v9p); > + do_mkdir(v9p, "/", "08"); > + do_lcreate(v9p, "08", "real_file"); > + g_assert(stat(real_file, &st_real) == 0); > + g_assert((st_real.st_mode & S_IFMT) == S_IFREG); > + > + do_hardlink(v9p, "08", "hardlink_file", "08/real_file"); > + g_assert(stat(hardlink_file, &st_link) == 0); > + > + do_unlinkat(v9p, "08", "hardlink_file", 0); > + /* symlink should be gone now */ > + g_assert(stat(hardlink_file, &st_link) != 0); > + /* and old file should still exist */ > + g_assert(stat(real_file, &st_real) == 0); > + > + g_free(hardlink_file); > + g_free(real_file); > +} > + > static void *assign_9p_local_driver(GString *cmd_line, void *arg) > { > virtio_9p_assign_local_driver(cmd_line, "security_model=mapped-xattr"); > @@ -1438,6 +1466,8 @@ static void register_virtio_9p_test(void) > qos_add_test("local/unlinkat_symlink", "virtio-9p", fs_unlinkat_symlink, > &opts); > qos_add_test("local/hardlink_file", "virtio-9p", fs_hardlink_file, &opts); > + qos_add_test("local/unlinkat_hardlink", "virtio-9p", fs_unlinkat_hardlink, > + &opts); > } > > libqos_init(register_virtio_9p_test);