From: Klaus Jensen <its@irrelevant.dk>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Klaus Jensen <k.jensen@samsung.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v3 12/17] hw/block/nvme: add support for scatter gather lists
Date: Fri, 23 Oct 2020 08:27:39 +0200 [thread overview]
Message-ID: <20201023062739.GC244769@apples.localdomain> (raw)
In-Reply-To: <473d4fd5-62d9-3856-5bbe-edba1ac5040f@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Oct 22 22:51, Philippe Mathieu-Daudé wrote:
> On 9/22/20 10:45 AM, Klaus Jensen wrote:
> > +static uint16_t nvme_dma(NvmeCtrl *n, uint8_t *ptr, uint32_t len,
>
> Using a 'void *ptr' would simplify your API, avoiding the callers
> to cast.
>
You are correct, but there is a bunch of work being done on top of
nvme-next right now - so even though it is not in master yet, I'd rather
not make too many fixups that trickles down like this.
But I will queue something up for this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-23 6:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 8:45 [PATCH v3 00/17] hw/block/nvme: multiple namespaces support Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 01/17] hw/block/nvme: fix typo in trace event Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 02/17] pci: pass along the return value of dma_memory_rw Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 03/17] hw/block/nvme: handle dma errors Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 04/17] hw/block/nvme: commonize nvme_rw error handling Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 05/17] hw/block/nvme: alignment style fixes Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 06/17] hw/block/nvme: add a lba to bytes helper Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 07/17] hw/block/nvme: fix endian conversion Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 08/17] hw/block/nvme: add symbolic command name to trace events Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 09/17] hw/block/nvme: refactor aio submission Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 10/17] hw/block/nvme: default request status to success Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 11/17] hw/block/nvme: harden cmb access Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 12/17] hw/block/nvme: add support for scatter gather lists Klaus Jensen
2020-10-22 20:51 ` Philippe Mathieu-Daudé
2020-10-23 6:27 ` Klaus Jensen [this message]
2020-09-22 8:45 ` [PATCH v3 13/17] hw/block/nvme: add support for sgl bit bucket descriptor Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 14/17] hw/block/nvme: refactor identify active namespace id list Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 15/17] hw/block/nvme: support multiple namespaces Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 16/17] pci: allocate pci id for nvme Klaus Jensen
2020-09-22 8:45 ` [PATCH v3 17/17] hw/block/nvme: change controller pci id Klaus Jensen
2020-09-22 15:31 ` [PATCH v3 00/17] hw/block/nvme: multiple namespaces support Keith Busch
2020-09-22 17:27 ` Klaus Jensen
2020-09-22 17:34 ` Keith Busch
2020-09-23 19:19 ` Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023062739.GC244769@apples.localdomain \
--to=its@irrelevant.dk \
--cc=ehabkost@redhat.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).