From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Sergio Lopez <slp@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
qemu-arm@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [PATCH 5/8] arm/virt: add acpi dsdt entry for xhci
Date: Fri, 23 Oct 2020 09:10:19 +0200 [thread overview]
Message-ID: <20201023071022.24916-6-kraxel@redhat.com> (raw)
In-Reply-To: <20201023071022.24916-1-kraxel@redhat.com>
Also tweak xhci_sysbus_build_aml, add _UID and _CCA.
Without _CCA the linux kernel's xhci probe fails on arm.
ASL changes:
Device (XHCI)
{
Name (_HID, EisaId ("PNP0D10") /* XHCI USB Controller with debug */) // _HID: Hardware ID
+ Name (_UID, Zero) // _UID: Unique ID
+ Name (_CCA, One) // _CCA: Cache Coherency Attribute
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
Memory32Fixed (ReadWrite,
0xFE900000, // Address Base
0x00004000, // Address Length
)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
{
0x0000000A,
}
})
}
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/arm/virt-acpi-build.c | 6 ++++++
hw/usb/hcd-xhci-sysbus.c | 2 ++
2 files changed, 8 insertions(+)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 9747a6458f0b..147332b37597 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -54,6 +54,7 @@
#include "kvm_arm.h"
#include "migration/vmstate.h"
#include "hw/acpi/ghes.h"
+#include "hw/usb/xhci.h"
#define ARM_SPI_BASE 32
@@ -631,6 +632,11 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms)
}
}
+ if (machine_usb(MACHINE(vms))) {
+ xhci_sysbus_build_aml(scope, memmap[VIRT_XHCI].base,
+ irqmap[VIRT_XHCI] + ARM_SPI_BASE);
+ }
+
acpi_dsdt_add_power_button(scope);
acpi_dsdt_add_tpm(scope, vms);
diff --git a/hw/usb/hcd-xhci-sysbus.c b/hw/usb/hcd-xhci-sysbus.c
index 29185d2261fb..fa963a5de4fa 100644
--- a/hw/usb/hcd-xhci-sysbus.c
+++ b/hw/usb/hcd-xhci-sysbus.c
@@ -79,6 +79,8 @@ void xhci_sysbus_build_aml(Aml *scope, uint32_t mmio, unsigned int irq)
AML_EXCLUSIVE, &irq, 1));
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0D10")));
+ aml_append(dev, aml_name_decl("_UID", aml_int(0)));
+ aml_append(dev, aml_name_decl("_CCA", aml_int(1)));
aml_append(dev, aml_name_decl("_CRS", crs));
aml_append(scope, dev);
}
--
2.27.0
next prev parent reply other threads:[~2020-10-23 7:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 7:10 [PATCH 0/8] arm/virt: add usb support Gerd Hoffmann
2020-10-23 7:10 ` [PATCH 1/8] tests/acpi: allow updates for expected data files Gerd Hoffmann
2020-10-23 7:10 ` [PATCH 2/8] tests/acpi: add empty tests/data/acpi/virt/DSDT.usb file Gerd Hoffmann
2020-10-23 7:10 ` [PATCH 3/8] arm/virt: add support for -machine usb=on Gerd Hoffmann
2020-10-23 7:10 ` [PATCH 4/8] arm/virt: add device tree node for xhci Gerd Hoffmann
2020-10-23 7:10 ` Gerd Hoffmann [this message]
2020-10-23 7:10 ` [PATCH 6/8] tests/acpi: add usb testcase for virt Gerd Hoffmann
2020-10-23 7:10 ` [PATCH 7/8] tests/acpi: update expected data files Gerd Hoffmann
2020-10-23 7:10 ` [PATCH 8/8] tests/acpi: disallow updates for " Gerd Hoffmann
2020-10-23 11:36 ` [PATCH 0/8] arm/virt: add usb support Peter Maydell
2020-10-26 7:01 ` Gerd Hoffmann
2020-10-26 9:57 ` Peter Maydell
2020-10-27 6:56 ` Gerd Hoffmann
2020-10-23 16:03 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023071022.24916-6-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sai.pavan.boddu@xilinx.com \
--cc=shannon.zhaosl@gmail.com \
--cc=slp@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).