From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Li Qiang" <liq3ea@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH RESEND v3 10/10] pci: Let pci_dma_write() propagate MemTxResult
Date: Fri, 23 Oct 2020 17:19:23 +0200 [thread overview]
Message-ID: <20201023151923.3243652-11-philmd@redhat.com> (raw)
In-Reply-To: <20201023151923.3243652-1-philmd@redhat.com>
pci_dma_rw() returns a MemTxResult type.
Do not discard it, return it to the caller.
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/pci/pci.h | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 85b5786a5da..dd486cd941a 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -818,8 +818,20 @@ static inline MemTxResult pci_dma_read(PCIDevice *dev, dma_addr_t addr,
return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE);
}
-static inline int pci_dma_write(PCIDevice *dev, dma_addr_t addr,
- const void *buf, dma_addr_t len)
+/**
+ * pci_dma_write: Write to address space from PCI device.
+ *
+ * Return a MemTxResult indicating whether the operation succeeded
+ * or failed (eg unassigned memory, device rejected the transaction,
+ * IOMMU fault).
+ *
+ * @dev: #PCIDevice doing the memory access
+ * @addr: address within the #PCIDevice address space
+ * @buf: buffer with the data transferred
+ * @len: the number of bytes to write
+ */
+static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr,
+ const void *buf, dma_addr_t len)
{
return pci_dma_rw(dev, addr, (void *) buf, len, DMA_DIRECTION_FROM_DEVICE);
}
--
2.26.2
next prev parent reply other threads:[~2020-10-23 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 15:19 [PATCH RESEND v3 00/10] hw: Let DMA/PCI API propagate MemTxResult Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 01/10] pci: pass along the return value of dma_memory_rw Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 02/10] docs/devel/loads-stores: Add regexp for DMA functions Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 03/10] dma: Document address_space_map/address_space_unmap() prototypes Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 04/10] dma: Let dma_memory_set() propagate MemTxResult Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 05/10] dma: Let dma_memory_rw() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 06/10] dma: Let dma_memory_read() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 07/10] dma: Let dma_memory_write() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 08/10] pci: Let pci_dma_rw() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 09/10] pci: Let pci_dma_read() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` Philippe Mathieu-Daudé [this message]
2020-10-23 15:20 ` [PATCH RESEND v3 00/10] hw: Let DMA/PCI API " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023151923.3243652-11-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).