From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
"Li Qiang" <liq3ea@gmail.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Klaus Jensen" <k.jensen@samsung.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Keith Busch" <kbusch@kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH RESEND v3 01/10] pci: pass along the return value of dma_memory_rw
Date: Fri, 23 Oct 2020 17:19:14 +0200 [thread overview]
Message-ID: <20201023151923.3243652-2-philmd@redhat.com> (raw)
In-Reply-To: <20201023151923.3243652-1-philmd@redhat.com>
From: Klaus Jensen <k.jensen@samsung.com>
Some might actually care about the return value of dma_memory_rw. So
let us pass it along instead of ignoring it.
There are no existing users of the return value, so this patch should be
safe.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Keith Busch <kbusch@kernel.org>
Message-Id: <20191011070141.188713-2-its@irrelevant.dk>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/pci/pci.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 0a59a06b149..f19ffe6b4fe 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -783,8 +783,7 @@ static inline AddressSpace *pci_get_address_space(PCIDevice *dev)
static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr,
void *buf, dma_addr_t len, DMADirection dir)
{
- dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
- return 0;
+ return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
}
static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr,
--
2.26.2
next prev parent reply other threads:[~2020-10-23 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 15:19 [PATCH RESEND v3 00/10] hw: Let DMA/PCI API propagate MemTxResult Philippe Mathieu-Daudé
2020-10-23 15:19 ` Philippe Mathieu-Daudé [this message]
2020-10-23 15:19 ` [PATCH RESEND v3 02/10] docs/devel/loads-stores: Add regexp for DMA functions Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 03/10] dma: Document address_space_map/address_space_unmap() prototypes Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 04/10] dma: Let dma_memory_set() propagate MemTxResult Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 05/10] dma: Let dma_memory_rw() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 06/10] dma: Let dma_memory_read() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 07/10] dma: Let dma_memory_write() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 08/10] pci: Let pci_dma_rw() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 09/10] pci: Let pci_dma_read() " Philippe Mathieu-Daudé
2020-10-23 15:19 ` [PATCH RESEND v3 10/10] pci: Let pci_dma_write() " Philippe Mathieu-Daudé
2020-10-23 15:20 ` [PATCH RESEND v3 00/10] hw: Let DMA/PCI API " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023151923.3243652-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=edgar.iglesias@xilinx.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=liq3ea@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).