From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [qemu-web PATCH 6/7] Add link to "edit this page" for all pages
Date: Fri, 23 Oct 2020 16:29:56 +0100 [thread overview]
Message-ID: <20201023152957.488974-7-berrange@redhat.com> (raw)
In-Reply-To: <20201023152957.488974-1-berrange@redhat.com>
The link takes the user directly to the source markdown file in gitlab,
where they can press the "Edit" button and make changes directly in the
browser. They will be prompted to fork the project when committing the
changes if they don't already have a fork. The result is a commit which
can be submitted for review per the contributing guidelines.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
| 3 +++
assets/css/style-desktop.css | 4 ++++
assets/css/style.css | 2 +-
3 files changed, 8 insertions(+), 1 deletion(-)
--git a/_includes/footer.html b/_includes/footer.html
index 2dd247b..0a77d8e 100644
--- a/_includes/footer.html
+++ b/_includes/footer.html
@@ -1,4 +1,7 @@
<div id="footer">
+ <div id="edit-page">
+ <a href="https://gitlab.com/qemu-project/qemu-web/-/blob/master/{{page.path}}">edit this page</a>
+ </div>
<div id="external-links">
<ul class="style">
<li><a href="http://qemu-advent-calendar.org">Advent calendar</a></li>
diff --git a/assets/css/style-desktop.css b/assets/css/style-desktop.css
index d45ec15..19272ad 100644
--- a/assets/css/style-desktop.css
+++ b/assets/css/style-desktop.css
@@ -102,6 +102,10 @@
/* Footer */
/*********************************************************************************/
+ #edit-page {
+ text-align: right;
+ }
+
#licenses {
float: right;
}
diff --git a/assets/css/style.css b/assets/css/style.css
index e2fee29..50bbcd1 100644
--- a/assets/css/style.css
+++ b/assets/css/style.css
@@ -514,7 +514,7 @@
margin: 0em;
}
- #conservancy, #licenses {
+ #conservancy, #licenses, #edit-page {
padding: 0em;
padding-left: 1em;
padding-right: 1em;
--
2.26.2
next prev parent reply other threads:[~2020-10-23 16:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 15:29 [qemu-web PATCH 0/7] Tweaks to page footer and add "edit page" links Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 1/7] Convert files to UNIX line endings Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 2/7] gitlab: introduce a CI job to publish the site content Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 3/7] make all links be relative to the root Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 4/7] Make page header nav narrower Daniel P. Berrangé
2020-10-23 15:29 ` [qemu-web PATCH 5/7] Simplify and restructure the page footer Daniel P. Berrangé
2020-10-23 15:46 ` Paolo Bonzini
2020-10-23 16:46 ` Daniel P. Berrangé
2020-10-23 17:19 ` Paolo Bonzini
2020-10-23 15:29 ` Daniel P. Berrangé [this message]
2020-10-23 15:47 ` [qemu-web PATCH 6/7] Add link to "edit this page" for all pages Paolo Bonzini
2020-10-23 16:19 ` Daniel P. Berrangé
2020-10-23 17:07 ` Paolo Bonzini
2020-10-23 15:29 ` [qemu-web PATCH 7/7] Add a CONTRIBUTING.md file as guidance for contributors Daniel P. Berrangé
2020-10-23 15:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023152957.488974-7-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).