From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
marcandre.lureau@redhat.com, pbonzini@redhat.com
Subject: [PATCH v2 0/6] qemu-storage-daemon: QAPIfy --chardev
Date: Fri, 23 Oct 2020 18:13:06 +0200 [thread overview]
Message-ID: <20201023161312.460406-1-kwolf@redhat.com> (raw)
While the qemu-storage-daemon command line is still considered unstable,
let's change --chardev from the old QemuOpts-based parser to QAPI, so
that it becomes a simple mapping of chardev-add to the command line and
will fit in a future fully QAPIfied command line without later
incompatible changes or additional compatibility glue.
v2:
- Use g_autoptr in qemu_chr_print_types() [Marc-André]
- Fixed build failures with spice [Marc-André]
- Fixed documentation generation [Markus]
- Make sure that no simple union variant contains a 'data' branch that
would make conversion to flat representation much more complicated
Kevin Wolf (6):
char/stdio: Fix QMP default for 'signal'
char: Factor out qemu_chr_print_types()
qapi: Remove wrapper struct for simple unions
qapi: Optionally parse simple unions as flat
tests/qapi-schema: Flat representation of simple unions
qemu-storage-daemon: Use qmp_chardev_add() for --chardev
qapi/char.json | 6 +-
docs/devel/qapi-code-gen.txt | 43 +++++++---
docs/sphinx/qapidoc.py | 14 ++--
include/chardev/char.h | 1 +
include/qapi/visitor-impl.h | 3 +
include/qapi/visitor.h | 10 +++
backends/tpm/tpm_emulator.c | 3 +-
backends/tpm/tpm_passthrough.c | 4 +-
block/crypto.c | 3 +-
block/qcow2.c | 9 +-
block/vmdk.c | 14 ++--
blockdev.c | 36 ++++----
chardev/char-file.c | 5 +-
chardev/char-mux.c | 5 +-
chardev/char-parallel.c | 5 +-
chardev/char-pipe.c | 7 +-
chardev/char-ringbuf.c | 5 +-
chardev/char-serial.c | 5 +-
chardev/char-socket.c | 13 ++-
chardev/char-stdio.c | 9 +-
chardev/char-udp.c | 11 +--
chardev/char.c | 26 +++---
chardev/msmouse.c | 4 +-
chardev/spice.c | 10 +--
chardev/wctablet.c | 4 +-
hw/core/numa.c | 6 +-
hw/display/xenfb.c | 8 +-
hw/input/hid.c | 8 +-
hw/input/ps2.c | 6 +-
hw/input/virtio-input-hid.c | 8 +-
hw/mem/pc-dimm.c | 18 ++--
hw/virtio/virtio-mem-pci.c | 3 +-
hw/virtio/virtio-pmem-pci.c | 3 +-
monitor/hmp-cmds.c | 14 ++--
qapi/qapi-visit-core.c | 10 +++
qemu-keymap.c | 2 +-
replay/replay-input.c | 46 +++++-----
storage-daemon/qemu-storage-daemon.c | 47 +++++++++--
tests/test-char.c | 12 ++-
tests/test-clone-visitor.c | 14 ++--
tests/test-qmp-cmds.c | 2 +-
tests/test-qobject-input-visitor.c | 24 +++---
tests/test-qobject-output-visitor.c | 24 +++---
ui/console.c | 5 +-
ui/input-keymap.c | 12 +--
ui/input-legacy.c | 12 +--
ui/input.c | 43 +++++-----
ui/spice-app.c | 5 +-
util/qemu-sockets.c | 8 +-
scripts/qapi/expr.py | 7 +-
scripts/qapi/introspect.py | 7 +-
scripts/qapi/schema.py | 74 +++++++++++++---
scripts/qapi/visit.py | 36 ++++++++
tests/qapi-schema/doc-good.out | 8 +-
tests/qapi-schema/flat-union-allow-flat.err | 2 +
tests/qapi-schema/flat-union-allow-flat.json | 10 +++
tests/qapi-schema/flat-union-allow-flat.out | 0
tests/qapi-schema/meson.build | 5 ++
tests/qapi-schema/qapi-schema-test.json | 10 +++
tests/qapi-schema/qapi-schema-test.out | 84 +++++++------------
tests/qapi-schema/union-allow-flat-bad.err | 2 +
tests/qapi-schema/union-allow-flat-bad.json | 5 ++
tests/qapi-schema/union-allow-flat-bad.out | 0
.../union-allow-flat-builtin-type.err | 2 +
.../union-allow-flat-builtin-type.json | 5 ++
.../union-allow-flat-builtin-type.out | 0
tests/qapi-schema/union-clash-member-data.err | 2 +
.../qapi-schema/union-clash-member-data.json | 6 ++
tests/qapi-schema/union-clash-member-data.out | 0
tests/qapi-schema/union-clash-member-type.err | 2 +
.../qapi-schema/union-clash-member-type.json | 6 ++
tests/qapi-schema/union-clash-member-type.out | 0
72 files changed, 517 insertions(+), 351 deletions(-)
create mode 100644 tests/qapi-schema/flat-union-allow-flat.err
create mode 100644 tests/qapi-schema/flat-union-allow-flat.json
create mode 100644 tests/qapi-schema/flat-union-allow-flat.out
create mode 100644 tests/qapi-schema/union-allow-flat-bad.err
create mode 100644 tests/qapi-schema/union-allow-flat-bad.json
create mode 100644 tests/qapi-schema/union-allow-flat-bad.out
create mode 100644 tests/qapi-schema/union-allow-flat-builtin-type.err
create mode 100644 tests/qapi-schema/union-allow-flat-builtin-type.json
create mode 100644 tests/qapi-schema/union-allow-flat-builtin-type.out
create mode 100644 tests/qapi-schema/union-clash-member-data.err
create mode 100644 tests/qapi-schema/union-clash-member-data.json
create mode 100644 tests/qapi-schema/union-clash-member-data.out
create mode 100644 tests/qapi-schema/union-clash-member-type.err
create mode 100644 tests/qapi-schema/union-clash-member-type.json
create mode 100644 tests/qapi-schema/union-clash-member-type.out
--
2.28.0
next reply other threads:[~2020-10-23 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 16:13 Kevin Wolf [this message]
2020-10-23 16:13 ` [PATCH v2 1/6] char/stdio: Fix QMP default for 'signal' Kevin Wolf
2020-10-23 16:13 ` [PATCH v2 2/6] char: Factor out qemu_chr_print_types() Kevin Wolf
2020-10-23 16:13 ` [PATCH v2 3/6] qapi: Remove wrapper struct for simple unions Kevin Wolf
2020-10-25 9:16 ` Markus Armbruster
2020-10-26 11:04 ` Kevin Wolf
2020-10-23 16:13 ` [PATCH v2 4/6] qapi: Optionally parse simple unions as flat Kevin Wolf
2020-10-23 16:13 ` [PATCH v2 5/6] tests/qapi-schema: Flat representation of simple unions Kevin Wolf
2020-10-23 16:13 ` [PATCH v2 6/6] qemu-storage-daemon: Use qmp_chardev_add() for --chardev Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023161312.460406-1-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).