From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 012A6C388F9 for ; Fri, 23 Oct 2020 18:35:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B8F420882 for ; Fri, 23 Oct 2020 18:35:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ykr3zp6x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8F420882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kW1uf-0007v1-HB for qemu-devel@archiver.kernel.org; Fri, 23 Oct 2020 14:35:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kW1tk-00072y-Ro for qemu-devel@nongnu.org; Fri, 23 Oct 2020 14:34:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kW1tj-00018x-Bv for qemu-devel@nongnu.org; Fri, 23 Oct 2020 14:34:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603478082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=54vRvNP2niJDvIDEZu13+zYc34Xn7omul0lVlg8bNo0=; b=Ykr3zp6xwhzbZiKHREGTVrZMQYuAKAAJV27TXlFiRNMl1Z9/U4MpqVffv6Z6UFVoxytBEB s0eAxr1nbBxERteRqn4M0cETiiEEwAY26Zs8kXZ2FfYArafyXHHbvb9VMKHQ8TZ4Pzen1f dLnyD4NYHNQvBylZZmpruRJlDjBewZY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-MbzMEwoJOkqfVeR6sQbnKQ-1; Fri, 23 Oct 2020 14:34:40 -0400 X-MC-Unique: MbzMEwoJOkqfVeR6sQbnKQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BB08018C89CE; Fri, 23 Oct 2020 18:34:39 +0000 (UTC) Received: from localhost (unknown [10.40.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id CC91260DA0; Fri, 23 Oct 2020 18:34:37 +0000 (UTC) Date: Fri, 23 Oct 2020 20:34:36 +0200 From: Igor Mammedov To: Eduardo Habkost Subject: Re: [PATCH 18/24] arm/cpu64: Register "aarch64" as class property Message-ID: <20201023203436.1f6d5d87@redhat.com> In-Reply-To: <20200921221045.699690-19-ehabkost@redhat.com> References: <20200921221045.699690-1-ehabkost@redhat.com> <20200921221045.699690-19-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/23 01:44:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Daniel P. Berrange" , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 21 Sep 2020 18:10:39 -0400 Eduardo Habkost wrote: > Class properties make QOM introspection simpler and easier, as > they don't require an object to be instantiated. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: Peter Maydell > Cc: qemu-arm@nongnu.org > Cc: qemu-devel@nongnu.org > --- > target/arm/cpu64.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c > index 3c2b3d95993..349c9fa3a3a 100644 > --- a/target/arm/cpu64.c > +++ b/target/arm/cpu64.c > @@ -758,15 +758,6 @@ static void aarch64_cpu_set_aarch64(Object *obj, bool value, Error **errp) > } > } > > -static void aarch64_cpu_initfn(Object *obj) > -{ > - object_property_add_bool(obj, "aarch64", aarch64_cpu_get_aarch64, > - aarch64_cpu_set_aarch64); > - object_property_set_description(obj, "aarch64", > - "Set on/off to enable/disable aarch64 " > - "execution state "); > -} > - > static void aarch64_cpu_finalizefn(Object *obj) > { > } > @@ -786,6 +777,12 @@ static void aarch64_cpu_class_init(ObjectClass *oc, void *data) > cc->gdb_num_core_regs = 34; > cc->gdb_core_xml_file = "aarch64-core.xml"; > cc->gdb_arch_name = aarch64_gdb_arch_name; > + > + object_class_property_add_bool(oc, "aarch64", aarch64_cpu_get_aarch64, > + aarch64_cpu_set_aarch64); > + object_class_property_set_description(oc, "aarch64", > + "Set on/off to enable/disable aarch64 " > + "execution state "); > } > > static void aarch64_cpu_instance_init(Object *obj) > @@ -823,7 +820,6 @@ static const TypeInfo aarch64_cpu_type_info = { > .name = TYPE_AARCH64_CPU, > .parent = TYPE_ARM_CPU, > .instance_size = sizeof(ARMCPU), > - .instance_init = aarch64_cpu_initfn, > .instance_finalize = aarch64_cpu_finalizefn, > .abstract = true, > .class_size = sizeof(AArch64CPUClass),