qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level
Date: Mon, 26 Oct 2020 17:13:40 +0000	[thread overview]
Message-ID: <20201026171340.GB152260@work-vm> (raw)
In-Reply-To: <20201008110148.2757734-1-misono.tomohiro@jp.fujitsu.com>

* Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote:
> Just noticed that although help message says default log level is INFO,
> it is actually 0 (EMRGE) and no mesage will be shown when error occurs.
> It's better to follow help message.
> 
> Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>

Queued

> ---
>  tools/virtiofsd/passthrough_ll.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index 0b229ebd57..4ff9f1b688 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -2888,12 +2888,11 @@ int main(int argc, char *argv[])
>          goto err_out1;
>      }
>  
> -    /*
> -     * log_level is 0 if not configured via cmd options (0 is LOG_EMERG,
> -     * and we don't use this log level).
> -     */
>      if (opts.log_level != 0) {
>          current_log_level = opts.log_level;
> +    } else {
> +        /* default log level is INFO */
> +        current_log_level = FUSE_LOG_INFO;
>      }
>      lo.debug = opts.debug;
>      if (lo.debug) {
> -- 
> 2.25.4
> 
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



      parent reply	other threads:[~2020-10-26 17:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 11:01 [PATCH] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Misono Tomohiro
2020-10-08 15:09 ` [Virtio-fs] " Stefan Hajnoczi
2020-10-26 17:13 ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201026171340.GB152260@work-vm \
    --to=dgilbert@redhat.com \
    --cc=misono.tomohiro@jp.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).