From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>, Matus Kysel <mkysel@tachyum.com>
Subject: [PULL 7/8] linux-user: correct errno returned from accept4() syscall
Date: Mon, 26 Oct 2020 23:03:38 +0100 [thread overview]
Message-ID: <20201026220339.195790-8-laurent@vivier.eu> (raw)
In-Reply-To: <20201026220339.195790-1-laurent@vivier.eu>
From: Matus Kysel <mkysel@tachyum.com>
accept4() returned wrong errno, that did not match current linux
Signed-off-by: Matus Kysel <mkysel@tachyum.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200930151616.3588165-1-mkysel@tachyum.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/syscall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index f0df6aecef80..6fef8181e738 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -3491,16 +3491,16 @@ static abi_long do_accept4(int fd, abi_ulong target_addr,
return get_errno(safe_accept4(fd, NULL, NULL, host_flags));
}
- /* linux returns EINVAL if addrlen pointer is invalid */
+ /* linux returns EFAULT if addrlen pointer is invalid */
if (get_user_u32(addrlen, target_addrlen_addr))
- return -TARGET_EINVAL;
+ return -TARGET_EFAULT;
if ((int)addrlen < 0) {
return -TARGET_EINVAL;
}
if (!access_ok(VERIFY_WRITE, target_addr, addrlen))
- return -TARGET_EINVAL;
+ return -TARGET_EFAULT;
addr = alloca(addrlen);
--
2.26.2
next prev parent reply other threads:[~2020-10-26 22:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 22:03 [PULL 0/8] Linux user for 5.2 patches Laurent Vivier
2020-10-26 22:03 ` [PULL 1/8] Fix stack smashing when handling PR_GET_PDEATHSIG Laurent Vivier
2020-10-26 22:03 ` [PULL 2/8] linux-user: Support f_flags in statfs64 when available Laurent Vivier
2020-10-26 22:03 ` [PULL 3/8] linux-user: update syscall_nr.h to Linux 5.9-rc7 Laurent Vivier
2020-10-26 22:03 ` [PULL 4/8] linux-user: update mips/syscall-args-o32.c.inc " Laurent Vivier
2020-10-26 22:03 ` [PULL 5/8] linux-user: update syscall.tbl " Laurent Vivier
2020-10-26 22:03 ` [PULL 6/8] linux-user: remove _sysctl Laurent Vivier
2020-10-26 22:03 ` Laurent Vivier [this message]
2020-10-26 22:03 ` [PULL 8/8] target/xtensa: enable all coprocessors for linux-user Laurent Vivier
2020-10-28 16:25 ` [PULL 0/8] Linux user for 5.2 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026220339.195790-8-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=mkysel@tachyum.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).