Re: [qemu-web PATCH v2 11/16] Bring contribution links out of the footer into the home page

[Kashyap Chamarthy <kchamart@redhat.com>]

On Tue, Oct 27, 2020 at 01:20:10PM +0000, Daniel P. Berrangé wrote:
> The selection of contribution links are important information to present
> to visitors to the site. They are best placed in a prominent position on
> the home page rather than in the footer
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Yeah, I personally didn't realize all the useful Contribute-related
links that were only one scroll away in the old page vs. having it front
and center in your new rendering:

    https://berrange.gitlab.io/qemu-web/

Definitely useful.

FWIW:

    Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>    

> ---
>  _includes/footer.html | 7 -------
>  index.html            | 8 ++++++++
>  2 files changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/_includes/footer.html b/_includes/footer.html
> index 411ff55..07f7866 100644
> --- a/_includes/footer.html
> +++ b/_includes/footer.html
> @@ -5,13 +5,6 @@
>  			<li><a href="{{ relative_root }}/download">Download</a></li>
>  			<li><a href="http://qemu-advent-calendar.org">QEMU advent calendar</a></li>
>  		</ul>
> -		<ul class="style">
> -			<li><a href="{{ relative_root }}/contribute">Contribute</a></li>
> -			<li><a href="{{ relative_root }}/contribute/report-a-bug">Reporting a bug</a></li>
> -			<li><a href="https://wiki.qemu.org/Documentation/GettingStartedDevelopers">New contributors</a></li>
> -			<li><a href="https://wiki.qemu.org/Contribute/SubmitAPatch">Submitting a patch</a></li>
> -			<li><a href="https://wiki.qemu.org/Contribute/FAQ">Contributor FAQ</a></li>
> -		</ul>
>  		<ul class="style">
>  			<li><a href="{{ relative_root }}/documentation">Documentation</a></li>
>  			<li><a href="https://www.qemu.org/docs/master/">Main docs</a></li>
> diff --git a/index.html b/index.html
> index d057a87..be1d210 100644
> --- a/index.html
> +++ b/index.html
> @@ -27,6 +27,14 @@ bxslider: True
>  			  <span><a href="{{ relative_root }}/download">Other releases</a></span>
>  			</li>
>  {% endfor %}
> +
> +			<li><strong>Contribute</strong>
> +			  <span><a href="{{ relative_root }}/contribute">Overview</a></span>
> +			  <span><a href="{{ relative_root }}/contribute/report-a-bug">Reporting a bug</a></span>
> +			  <span><a href="https://wiki.qemu.org/Documentation/GettingStartedDevelopers">New contributors</a></span>
> +			  <span><a href="https://wiki.qemu.org/Contribute/SubmitAPatch">Submitting a patch</a></span>
> +			  <span><a href="https://wiki.qemu.org/Contribute/FAQ">Contributor FAQ</a></span>
> +			</li>
>  		</ul>
>  	</div>
>  </div>
> -- 
> 2.26.2
> 
> 

-- 
/kashyap