From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
"Greg Kurz" <groug@kaod.org>,
pbonzini@redhat.com, "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 3/8] cpus: Drop declaration of cpu_remove()
Date: Tue, 27 Oct 2020 17:30:09 +0100 [thread overview]
Message-ID: <20201027163014.247336-4-laurent@vivier.eu> (raw)
In-Reply-To: <20201027163014.247336-1-laurent@vivier.eu>
From: Greg Kurz <groug@kaod.org>
cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0,
but its prototype wasn't removed. We could possibly keep the shorter
cpu_remove() naming but it seems better to highligth that this blocks
until the CPU thread is joined.
Fixes: dbadee4ff4a0 ("cpus: join thread when removing a vCPU")
Cc: pbonzini@redhat.com
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <160268285707.1107461.15035929822602623985.stgit@bahia.lan>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
include/hw/core/cpu.h | 8 --------
1 file changed, 8 deletions(-)
diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index 9c3a45ad7b11..3d92c967fffa 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -927,14 +927,6 @@ void cpu_exit(CPUState *cpu);
void cpu_resume(CPUState *cpu);
/**
- * cpu_remove:
- * @cpu: The CPU to remove.
- *
- * Requests the CPU to be removed.
- */
-void cpu_remove(CPUState *cpu);
-
- /**
* cpu_remove_sync:
* @cpu: The CPU to remove.
*
--
2.26.2
next prev parent reply other threads:[~2020-10-27 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 16:30 [PULL 0/8] Trivial branch for 5.2 patches Laurent Vivier
2020-10-27 16:30 ` [PULL 1/8] elf2dmp: Fix memory leak on main() error paths Laurent Vivier
2020-10-27 16:30 ` [PULL 2/8] Makefile: Add *.[ch].inc files to cscope/ctags/TAGS Laurent Vivier
2020-10-27 16:30 ` Laurent Vivier [this message]
2020-10-27 16:30 ` [PULL 4/8] io: Fix Lesser GPL version number Laurent Vivier
2020-10-27 16:30 ` [PULL 5/8] cryptodev: " Laurent Vivier
2020-10-27 16:30 ` [PULL 6/8] scripts/qmp: delete 'qmp' script Laurent Vivier
2020-10-27 16:30 ` [PULL 7/8] qdev: Fix two typos Laurent Vivier
2020-10-27 16:30 ` [PULL 8/8] CHANGELOG: remove disused file Laurent Vivier
2020-10-30 19:44 ` [PULL 0/8] Trivial branch for 5.2 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027163014.247336-4-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=groug@kaod.org \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).