From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E502C4363A for ; Tue, 27 Oct 2020 18:56:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62C93207E8 for ; Tue, 27 Oct 2020 18:56:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CKcm9hXl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62C93207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXU99-0001cd-Dd for qemu-devel@archiver.kernel.org; Tue, 27 Oct 2020 14:56:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXTmy-0001p8-Np for qemu-devel@nongnu.org; Tue, 27 Oct 2020 14:33:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:25508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXTmv-0004d9-6y for qemu-devel@nongnu.org; Tue, 27 Oct 2020 14:33:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603823616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ep4Y3/jxjuhVIBM0XsWNeIzywqqN2AhfD96PpuUSXXI=; b=CKcm9hXlnsjEUadJXVook4BtYJb8HaSgB1VcOGerHR0RDAfGroDTdNnM+kGM99CcqFM7UP jufH4vYVxNa4hDSaUwhYQddZpwWC6J7OWXmjHbqYDLEj+gdcto3i8gUS4b7rblESkeciZX A+LX/KteuxlIj/leOaco8VMslhbae04= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-a9fPIWftNyShIUWiQtF24Q-1; Tue, 27 Oct 2020 14:33:32 -0400 X-MC-Unique: a9fPIWftNyShIUWiQtF24Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 41F6C59; Tue, 27 Oct 2020 18:33:31 +0000 (UTC) Received: from work-vm (ovpn-115-62.ams2.redhat.com [10.36.115.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70BB65C1C2; Tue, 27 Oct 2020 18:33:27 +0000 (UTC) Date: Tue, 27 Oct 2020 18:33:19 +0000 From: "Dr. David Alan Gilbert" To: Jiachen Zhang Subject: Re: [PATCH] virtiofsd: Fix the help message of posix lock Message-ID: <20201027183319.GR3369@work-vm> References: <20201027081558.29904-1-zhangjiachen.jaycee@bytedance.com> MIME-Version: 1.0 In-Reply-To: <20201027081558.29904-1-zhangjiachen.jaycee@bytedance.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:07 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Jiachen Zhang (zhangjiachen.jaycee@bytedance.com) wrote: > The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote > posix locks by default. But the --help message still says it is enabled > by default. So fix it to output no_posix_lock. > > Signed-off-by: Jiachen Zhang Thanks! Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c > index 85770d63f1..574dd09e91 100644 > --- a/tools/virtiofsd/helper.c > +++ b/tools/virtiofsd/helper.c > @@ -161,7 +161,7 @@ void fuse_cmdline_help(void) > " allowed (default: 10)\n" > " -o posix_lock|no_posix_lock\n" > " enable/disable remote posix lock\n" > - " default: posix_lock\n" > + " default: no_posix_lock\n" > " -o readdirplus|no_readdirplus\n" > " enable/disable readirplus\n" > " default: readdirplus except with " > -- > 2.20.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK