From: Joelle van Dyne <j@getutm.app>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Joelle van Dyne <j@getutm.app>,
"open list:raw" <qemu-block@nongnu.org>,
Max Reitz <mreitz@redhat.com>
Subject: [PATCH v3 1/7] configure: option to disable host block devices
Date: Tue, 27 Oct 2020 20:06:55 -0700 [thread overview]
Message-ID: <20201028030701.14086-2-j@getutm.app> (raw)
In-Reply-To: <20201028030701.14086-1-j@getutm.app>
Some hosts (iOS) have a sandboxed filesystem and do not provide low-level
APIs for interfacing with host block devices.
Signed-off-by: Joelle van Dyne <j@getutm.app>
---
configure | 4 ++++
meson.build | 1 +
block/file-posix.c | 8 +++++++-
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 71bbe82ac5..4e68a5fefe 100755
--- a/configure
+++ b/configure
@@ -448,6 +448,7 @@ ninja=""
skip_meson=no
gettext=""
mirror_jit="no"
+host_block_device_support="yes"
bogus_os="no"
malloc_trim="auto"
@@ -5901,6 +5902,9 @@ if test "$default_devices" = "yes" ; then
else
echo "CONFIG_MINIKCONF_MODE=--allnoconfig" >> $config_host_mak
fi
+if test "$host_block_device_support" = "yes" ; then
+ echo "CONFIG_HOST_BLOCK_DEVICE=y" >> $config_host_mak
+fi
if test "$debug_tcg" = "yes" ; then
echo "CONFIG_DEBUG_TCG=y" >> $config_host_mak
fi
diff --git a/meson.build b/meson.build
index 0a56fef146..e880274b7c 100644
--- a/meson.build
+++ b/meson.build
@@ -2149,6 +2149,7 @@ summary_info += {'vvfat support': config_host.has_key('CONFIG_VVFAT')}
summary_info += {'qed support': config_host.has_key('CONFIG_QED')}
summary_info += {'parallels support': config_host.has_key('CONFIG_PARALLELS')}
summary_info += {'sheepdog support': config_host.has_key('CONFIG_SHEEPDOG')}
+summary_info += {'host block dev support': config_host.has_key('CONFIG_HOST_BLOCK_DEVICE')}
summary_info += {'capstone': capstone_opt == 'disabled' ? false : capstone_opt}
summary_info += {'libpmem support': config_host.has_key('CONFIG_LIBPMEM')}
summary_info += {'libdaxctl support': config_host.has_key('CONFIG_LIBDAXCTL')}
diff --git a/block/file-posix.c b/block/file-posix.c
index c63926d592..52f7c20525 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -41,7 +41,7 @@
#include "scsi/pr-manager.h"
#include "scsi/constants.h"
-#if defined(__APPLE__) && (__MACH__)
+#if defined(CONFIG_HOST_BLOCK_DEVICE) && defined(__APPLE__) && (__MACH__)
#include <paths.h>
#include <sys/param.h>
#include <IOKit/IOKitLib.h>
@@ -3247,6 +3247,8 @@ BlockDriver bdrv_file = {
/***********************************************/
/* host device */
+#if defined(CONFIG_HOST_BLOCK_DEVICE)
+
#if defined(__APPLE__) && defined(__MACH__)
static kern_return_t GetBSDPath(io_iterator_t mediaIterator, char *bsdPath,
CFIndex maxPathSize, int flags);
@@ -3872,6 +3874,8 @@ static BlockDriver bdrv_host_cdrom = {
};
#endif /* __FreeBSD__ */
+#endif /* CONFIG_HOST_BLOCK_DEVICE */
+
static void bdrv_file_init(void)
{
/*
@@ -3879,6 +3883,7 @@ static void bdrv_file_init(void)
* registered last will get probed first.
*/
bdrv_register(&bdrv_file);
+#if defined(CONFIG_HOST_BLOCK_DEVICE)
bdrv_register(&bdrv_host_device);
#ifdef __linux__
bdrv_register(&bdrv_host_cdrom);
@@ -3886,6 +3891,7 @@ static void bdrv_file_init(void)
#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
bdrv_register(&bdrv_host_cdrom);
#endif
+#endif /* CONFIG_HOST_BLOCK_DEVICE */
}
block_init(bdrv_file_init);
--
2.28.0
next prev parent reply other threads:[~2020-10-28 3:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 3:06 [PATCH v3 0/7] iOS and Apple Silicon host support Joelle van Dyne
2020-10-28 3:06 ` Joelle van Dyne [this message]
2020-10-28 11:22 ` [PATCH v3 1/7] configure: option to disable host block devices Stefan Hajnoczi
2020-10-29 0:51 ` Joelle van Dyne
2020-10-28 3:06 ` [PATCH v3 2/7] configure: cross-compiling with empty cross_prefix Joelle van Dyne
2020-10-28 3:06 ` [PATCH v3 3/7] qemu: add support for iOS host Joelle van Dyne
2020-10-28 11:39 ` Stefan Hajnoczi
2020-10-29 0:55 ` Joelle van Dyne
2020-10-29 7:47 ` Stefan Hajnoczi
2020-10-28 3:06 ` [PATCH v3 4/7] coroutine: add libucontext as external library Joelle van Dyne
2020-10-28 11:47 ` Stefan Hajnoczi
2020-10-29 0:59 ` Joelle van Dyne
2020-10-29 7:08 ` Stefan Hajnoczi
2020-10-28 3:06 ` [PATCH v3 5/7] slirp: update build flags for iOS resolv fix Joelle van Dyne
2020-10-28 11:48 ` Stefan Hajnoczi
2020-10-28 3:07 ` [PATCH v3 6/7] tcg: implement JIT for iOS and Apple Silicon Joelle van Dyne
2020-10-28 11:53 ` Stefan Hajnoczi
2020-10-29 1:04 ` Joelle van Dyne
2020-10-29 8:13 ` Stefan Hajnoczi
2020-10-28 3:07 ` [PATCH v3 7/7] block: check availablity for preadv/pwritev on mac Joelle van Dyne
2020-10-28 11:59 ` Stefan Hajnoczi
2020-10-29 1:07 ` Joelle van Dyne
2020-10-29 7:53 ` Stefan Hajnoczi
2020-10-29 8:33 ` Joelle van Dyne
2020-10-28 12:05 ` [PATCH v3 0/7] iOS and Apple Silicon host support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028030701.14086-2-j@getutm.app \
--to=j@getutm.app \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).