* [PATCH] target/ppc/excp_helper: Add a fallthrough for fix compiler warning
@ 2020-10-28 5:51 Chen Qun
2020-10-28 5:53 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Chen Qun @ 2020-10-28 5:51 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: zhang.zhanghailiang, clg, ganqixin, Euler Robot, Chen Qun, david
When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
../target/ppc/excp_helper.c: In function ‘powerpc_excp’:
../target/ppc/excp_helper.c:529:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
529 | msr |= env->error_code;
| ~~~~^~~~~~~~~~~~~~~~~~
../target/ppc/excp_helper.c:530:5: note: here
530 | case POWERPC_EXCP_HDECR: /* Hypervisor decrementer exception */
| ^~~~
Add the corresponding "fall through" comment to fix it.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
target/ppc/excp_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index a988ba15f4..c639516399 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -527,6 +527,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int excp_model, int excp)
break;
case POWERPC_EXCP_HISI: /* Hypervisor instruction storage exception */
msr |= env->error_code;
+ /* fall through */
case POWERPC_EXCP_HDECR: /* Hypervisor decrementer exception */
case POWERPC_EXCP_HDSI: /* Hypervisor data storage exception */
case POWERPC_EXCP_HDSEG: /* Hypervisor data segment exception */
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/ppc/excp_helper: Add a fallthrough for fix compiler warning
2020-10-28 5:51 [PATCH] target/ppc/excp_helper: Add a fallthrough for fix compiler warning Chen Qun
@ 2020-10-28 5:53 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2020-10-28 5:53 UTC (permalink / raw)
To: Chen Qun
Cc: zhang.zhanghailiang, qemu-trivial, qemu-devel, clg, ganqixin,
Euler Robot
[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]
On Wed, Oct 28, 2020 at 01:51:07PM +0800, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> ../target/ppc/excp_helper.c: In function ‘powerpc_excp’:
> ../target/ppc/excp_helper.c:529:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 529 | msr |= env->error_code;
> | ~~~~^~~~~~~~~~~~~~~~~~
> ../target/ppc/excp_helper.c:530:5: note: here
> 530 | case POWERPC_EXCP_HDECR: /* Hypervisor decrementer exception */
> | ^~~~
>
> Add the corresponding "fall through" comment to fix it.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Applied to ppc-for-5.2, thanks.
> ---
> target/ppc/excp_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index a988ba15f4..c639516399 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -527,6 +527,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int excp_model, int excp)
> break;
> case POWERPC_EXCP_HISI: /* Hypervisor instruction storage exception */
> msr |= env->error_code;
> + /* fall through */
> case POWERPC_EXCP_HDECR: /* Hypervisor decrementer exception */
> case POWERPC_EXCP_HDSI: /* Hypervisor data storage exception */
> case POWERPC_EXCP_HDSEG: /* Hypervisor data segment exception */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-28 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-28 5:51 [PATCH] target/ppc/excp_helper: Add a fallthrough for fix compiler warning Chen Qun
2020-10-28 5:53 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).