From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org
Subject: [PATCH] docker, coverity_scan: unify Fedora dockerfiles
Date: Thu, 29 Oct 2020 13:22:22 -0400 [thread overview]
Message-ID: <20201029172222.3940324-2-pbonzini@redhat.com> (raw)
The Fedora CI and coverity runs are using a slightly different set of
packages Unfortunately we need to keep coverity on Fedora 30 because
it doesn't know about GCC 10 and fails, but we can at least base the
coverity dockerfile on one from tests/docker; this way the coverity run
is less likely to be forgotten when doing changes to the set of packages
in the containers.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scripts/coverity-scan/coverity-scan.docker | 109 +-----------------
tests/docker/dockerfiles/fedora.docker | 5 +
.../{fedora.docker => fedora30.docker} | 7 +-
3 files changed, 13 insertions(+), 108 deletions(-)
copy tests/docker/dockerfiles/{fedora.docker => fedora30.docker} (94%)
diff --git a/scripts/coverity-scan/coverity-scan.docker b/scripts/coverity-scan/coverity-scan.docker
index 501ac67233..1bfb856765 100644
--- a/scripts/coverity-scan/coverity-scan.docker
+++ b/scripts/coverity-scan/coverity-scan.docker
@@ -15,114 +15,9 @@
# The work of actually doing the build is handled by the
# run-coverity-scan script.
-FROM fedora:30
-ENV PACKAGES \
- alsa-lib-devel \
- bc \
- brlapi-devel \
- bzip2 \
- bzip2-devel \
- ccache \
- clang \
- curl \
- cyrus-sasl-devel \
- dbus-daemon \
- device-mapper-multipath-devel \
- findutils \
- gcc \
- gcc-c++ \
- gettext \
- git \
- glib2-devel \
- glusterfs-api-devel \
- gnutls-devel \
- gtk3-devel \
- hostname \
- libaio-devel \
- libasan \
- libattr-devel \
- libblockdev-mpath-devel \
- libcap-devel \
- libcap-ng-devel \
- libcurl-devel \
- libepoxy-devel \
- libfdt-devel \
- libgbm-devel \
- libiscsi-devel \
- libjpeg-devel \
- libpmem-devel \
- libnfs-devel \
- libpng-devel \
- librbd-devel \
- libseccomp-devel \
- libssh-devel \
- libubsan \
- libudev-devel \
- libusbx-devel \
- libxml2-devel \
- libzstd-devel \
- llvm \
- lzo-devel \
- make \
- mingw32-bzip2 \
- mingw32-curl \
- mingw32-glib2 \
- mingw32-gmp \
- mingw32-gnutls \
- mingw32-gtk3 \
- mingw32-libjpeg-turbo \
- mingw32-libpng \
- mingw32-libtasn1 \
- mingw32-nettle \
- mingw32-nsis \
- mingw32-pixman \
- mingw32-pkg-config \
- mingw32-SDL2 \
- mingw64-bzip2 \
- mingw64-curl \
- mingw64-glib2 \
- mingw64-gmp \
- mingw64-gnutls \
- mingw64-gtk3 \
- mingw64-libjpeg-turbo \
- mingw64-libpng \
- mingw64-libtasn1 \
- mingw64-nettle \
- mingw64-pixman \
- mingw64-pkg-config \
- mingw64-SDL2 \
- ncurses-devel \
- nettle-devel \
- nss-devel \
- numactl-devel \
- perl \
- perl-Test-Harness \
- pixman-devel \
- pulseaudio-libs-devel \
- python3 \
- python3-sphinx \
- PyYAML \
- rdma-core-devel \
- SDL2-devel \
- snappy-devel \
- sparse \
- spice-server-devel \
- systemd-devel \
- systemtap-sdt-devel \
- tar \
- usbredir-devel \
- virglrenderer-devel \
- vte291-devel \
- wget \
- which \
- xen-devel \
- xfsprogs-devel \
- zlib-devel
-ENV QEMU_CONFIGURE_OPTS --python=/usr/bin/python3
+FROM qemu:fedora
-RUN dnf install -y $PACKAGES
-RUN rpm -q $PACKAGES | sort > /packages.txt
-ENV PATH $PATH:/usr/libexec/python3-sphinx/
+RUN dnf install -y curl wget
ENV COVERITY_TOOL_BASE=/coverity-tools
COPY coverity_tool.tgz coverity_tool.tgz
RUN mkdir -p /coverity-tools/coverity_tool && cd /coverity-tools/coverity_tool && tar xf /coverity_tool.tgz
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 0b5053f2d0..54f3e10991 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -2,6 +2,7 @@ FROM fedora:32
# Please keep this list sorted alphabetically
ENV PACKAGES \
+ alsa-lib-devel \
bc \
brlapi-devel \
bzip2 \
@@ -31,8 +32,10 @@ ENV PACKAGES \
libcurl-devel \
libepoxy-devel \
libfdt-devel \
+ libgbm-devel \
libiscsi-devel \
libjpeg-devel \
+ libnfs-devel \
libpmem-devel \
libpng-devel \
librbd-devel \
@@ -82,6 +85,7 @@ ENV PACKAGES \
perl \
perl-Test-Harness \
pixman-devel \
+ pulseaudio-libs-devel \
python3 \
python3-PyYAML \
python3-numpy \
@@ -105,6 +109,7 @@ ENV PACKAGES \
vte291-devel \
which \
xen-devel \
+ xfsprogs-devel \
zlib-devel
ENV QEMU_CONFIGURE_OPTS --python=/usr/bin/python3
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora30.docker
similarity index 94%
copy from tests/docker/dockerfiles/fedora.docker
copy to tests/docker/dockerfiles/fedora30.docker
index 0b5053f2d0..7295b74d2a 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora30.docker
@@ -1,7 +1,8 @@
-FROM fedora:32
+FROM fedora:30
# Please keep this list sorted alphabetically
ENV PACKAGES \
+ alsa-lib-devel \
bc \
brlapi-devel \
bzip2 \
@@ -31,8 +32,10 @@ ENV PACKAGES \
libcurl-devel \
libepoxy-devel \
libfdt-devel \
+ libgbm-devel \
libiscsi-devel \
libjpeg-devel \
+ libnfs-devel \
libpmem-devel \
libpng-devel \
librbd-devel \
@@ -82,6 +85,7 @@ ENV PACKAGES \
perl \
perl-Test-Harness \
pixman-devel \
+ pulseaudio-libs-devel \
python3 \
python3-PyYAML \
python3-numpy \
@@ -105,6 +109,7 @@ ENV PACKAGES \
vte291-devel \
which \
xen-devel \
+ xfsprogs-devel \
zlib-devel
ENV QEMU_CONFIGURE_OPTS --python=/usr/bin/python3
--
2.26.2
reply other threads:[~2020-10-29 17:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029172222.3940324-2-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).