From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 00/15] pc,pci,vhost,virtio: misc fixes
Date: Mon, 2 Nov 2020 05:08:56 -0500 [thread overview]
Message-ID: <20201102050841-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAFEAcA_vzpTivJSGmM2aR56-z5adXe0hn9A8K+2Hb0KdR6sXkA@mail.gmail.com>
On Sun, Nov 01, 2020 at 02:03:56PM +0000, Peter Maydell wrote:
> On Fri, 30 Oct 2020 at 14:33, <no-reply@patchew.org> wrote:
> >
> > Patchew URL: https://patchew.org/QEMU/20201030141136.1013521-1-mst@redhat.com/
>
> I'll apply this pullreq (unless it has other more serious
> issues), but could you look at the coding style warnings in
> a followup patch, please?
Will do, thanks!
>
> > 9/15 Checking commit 660b206b990b (pc: Implement -no-hpet as sugar for -machine hpet=on)
> > WARNING: Block comments use a leading /* on a separate line
> > #53: FILE: hw/i386/pc.c:1152:
> > + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
> >
> > WARNING: Block comments should align the * on each line
> > #54: FILE: hw/i386/pc.c:1153:
> > + /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
> > + * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
> >
>
> > 13/15 Checking commit e013e462e230 (vhost-blk: set features before setting inflight feature)
> > ERROR: trailing whitespace
> > #45: FILE: hw/virtio/vhost.c:1651:
> > + $
> >
> > ERROR: trailing whitespace
> > #50: FILE: hw/virtio/vhost.c:1656:
> > + $
>
> These all look like nits that should be fixed.
>
> thanks
> -- PMM
next prev parent reply other threads:[~2020-11-02 10:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 14:11 [PULL 00/15] pc,pci,vhost,virtio: misc fixes Michael S. Tsirkin
2020-10-30 14:11 ` [PULL 01/15] vhost-vdpa: negotiate VIRTIO_NET_F_STATUS with driver Michael S. Tsirkin
2020-10-30 14:11 ` [PULL 02/15] vhost-vsock: set vhostfd to non-blocking mode Michael S. Tsirkin
2020-10-30 14:11 ` [PULL 03/15] acpi/crs: Prevent bad ranges for host bridges Michael S. Tsirkin
2020-10-30 14:11 ` [PULL 04/15] acpi/crs: Support ranges > 32b for hosts Michael S. Tsirkin
2020-10-30 14:11 ` [PULL 05/15] hw/virtio/vhost-vdpa: Fix Coverity CID 1432864 Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 06/15] hw/pci: Extract pci_bus_change_irq_level() from pci_change_irq_level() Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 07/15] pci: Assert irqnum is between 0 and bus->nirqs in pci_bus_change_irq_level Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 08/15] vhost: Don't special case vq->used_phys in vhost_get_log_size() Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 09/15] pc: Implement -no-hpet as sugar for -machine hpet=on Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 10/15] pci: advertise a page aligned ATS Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 11/15] pci: Change error_report to assert(3) Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 12/15] pci: Disallow improper BAR registration for type 1 Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 13/15] vhost-blk: set features before setting inflight feature Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 14/15] virtio: skip guest index check on device load Michael S. Tsirkin
2020-10-30 14:12 ` [PULL 15/15] intel_iommu: Fix two misuse of "0x%u" prints Michael S. Tsirkin
2020-10-30 14:33 ` [PULL 00/15] pc,pci,vhost,virtio: misc fixes no-reply
2020-11-01 14:03 ` Peter Maydell
2020-11-02 10:08 ` Michael S. Tsirkin [this message]
2020-11-01 19:05 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2020-10-30 12:45 Michael S. Tsirkin
2020-10-30 13:06 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102050841-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).