* [PATCH v2] pc: comment style fixup
@ 2020-11-02 10:28 Michael S. Tsirkin
2020-11-02 10:40 ` Philippe Mathieu-Daudé
2020-11-02 13:25 ` Chenqun (kuhn)
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2020-11-02 10:28 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Eduardo Habkost, Richard Henderson
Fix up checkpatch comment style warnings.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
changes from v1:
address philippe's comments
:w
hw/i386/pc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 416fb0e0f6..aae45ba779 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1149,10 +1149,11 @@ void pc_basic_device_init(struct PCMachineState *pcms,
error_report("couldn't create HPET device");
exit(1);
}
- /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
- * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
- * IRQ8 and IRQ2.
- */
+ /*
+ * For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 and
+ * earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, IRQ8 and
+ * IRQ2.
+ */
uint8_t compat = object_property_get_uint(OBJECT(hpet),
HPET_INTCAP, NULL);
if (!compat) {
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] pc: comment style fixup
2020-11-02 10:28 [PATCH v2] pc: comment style fixup Michael S. Tsirkin
@ 2020-11-02 10:40 ` Philippe Mathieu-Daudé
2020-11-02 13:25 ` Chenqun (kuhn)
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-02 10:40 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Paolo Bonzini, Eduardo Habkost, Richard Henderson
On 11/2/20 11:28 AM, Michael S. Tsirkin wrote:
> Fix up checkpatch comment style warnings.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> changes from v1:
> address philippe's comments
> :w
>
> hw/i386/pc.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Thanks!
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] pc: comment style fixup
2020-11-02 10:28 [PATCH v2] pc: comment style fixup Michael S. Tsirkin
2020-11-02 10:40 ` Philippe Mathieu-Daudé
@ 2020-11-02 13:25 ` Chenqun (kuhn)
1 sibling, 0 replies; 3+ messages in thread
From: Chenqun (kuhn) @ 2020-11-02 13:25 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel@nongnu.org
Cc: Paolo Bonzini, Eduardo Habkost, Richard Henderson
> -----Original Message-----
> From: Qemu-devel
> [mailto:qemu-devel-bounces+kuhn.chenqun=huawei.com@nongnu.org] On
> Behalf Of Michael S. Tsirkin
> Sent: Monday, November 2, 2020 6:29 PM
> To: qemu-devel@nongnu.org
> Cc: Paolo Bonzini <pbonzini@redhat.com>; Eduardo Habkost
> <ehabkost@redhat.com>; Richard Henderson <rth@twiddle.net>
> Subject: [PATCH v2] pc: comment style fixup
>
> Fix up checkpatch comment style warnings.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> changes from v1:
> address philippe's comments
> :w
>
> hw/i386/pc.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 416fb0e0f6..aae45ba779 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1149,10 +1149,11 @@ void pc_basic_device_init(struct PCMachineState
> *pcms,
> error_report("couldn't create HPET device");
> exit(1);
> }
> - /* For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7
> - * and earlier, use IRQ2 for compat. Otherwise, use IRQ16~23,
> - * IRQ8 and IRQ2.
> - */
> + /*
> + * For pc-piix-*, hpet's intcap is always IRQ2. For pc-q35-1.7 and
> + * earlier, use IRQ2 for compat. Otherwise, use IRQ16~23, IRQ8 and
> + * IRQ2.
> + */
> uint8_t compat = object_property_get_uint(OBJECT(hpet),
> HPET_INTCAP, NULL);
> if (!compat) {
> --
> MST
>
Reviewed-by: Chen Qun <kuhn.chenqun@huawei.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-02 13:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-02 10:28 [PATCH v2] pc: comment style fixup Michael S. Tsirkin
2020-11-02 10:40 ` Philippe Mathieu-Daudé
2020-11-02 13:25 ` Chenqun (kuhn)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).