From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Daniel P . Berrange" <berrange@redhat.com>,
qemu-devel@nongnu.org,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Cleber Rosa <crosa@redhat.com>, Thomas Huth <thuth@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Sarah Harris" <S.E.Harris@kent.ac.uk>,
"Michael Rolnik" <mrolnik@gmail.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Fabien Chouteau" <chouteau@adacore.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-ppc@nongnu.org, "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-arm@nongnu.org, "Antony Pavlov" <antonynpavlov@gmail.com>
Subject: [PATCH-for-5.2? 3/5] tests/acceptance: Skip incomplete virtio_version tests using '@skip'
Date: Mon, 2 Nov 2020 15:42:43 +0100 [thread overview]
Message-ID: <20201102144245.2134077-4-philmd@redhat.com> (raw)
In-Reply-To: <20201102144245.2134077-1-philmd@redhat.com>
Prefer skipping incomplete tests with the "@skip" keyword,
rather than commenting the code.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/acceptance/virtio_version.py | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/acceptance/virtio_version.py b/tests/acceptance/virtio_version.py
index 33593c29dd0..187bbfa1f42 100644
--- a/tests/acceptance/virtio_version.py
+++ b/tests/acceptance/virtio_version.py
@@ -140,17 +140,20 @@ def check_all_variants(self, qemu_devtype, virtio_devid):
self.assertIn('conventional-pci-device', trans_ifaces)
self.assertNotIn('pci-express-device', trans_ifaces)
+ @skip("virtio-blk requires 'driver' parameter")
+ def test_conventional_devs_driver(self):
+ self.check_all_variants('virtio-blk-pci', VIRTIO_BLOCK)
+
+ @skip("virtio-9p requires 'fsdev' parameter")
+ def test_conventional_devs_fsdev(self):
+ self.check_all_variants('virtio-9p-pci', VIRTIO_9P)
def test_conventional_devs(self):
self.check_all_variants('virtio-net-pci', VIRTIO_NET)
- # virtio-blk requires 'driver' parameter
- #self.check_all_variants('virtio-blk-pci', VIRTIO_BLOCK)
self.check_all_variants('virtio-serial-pci', VIRTIO_CONSOLE)
self.check_all_variants('virtio-rng-pci', VIRTIO_RNG)
self.check_all_variants('virtio-balloon-pci', VIRTIO_BALLOON)
self.check_all_variants('virtio-scsi-pci', VIRTIO_SCSI)
- # virtio-9p requires 'fsdev' parameter
- #self.check_all_variants('virtio-9p-pci', VIRTIO_9P)
def check_modern_only(self, qemu_devtype, virtio_devid):
"""Check if a modern-only virtio device type behaves as expected"""
--
2.26.2
next prev parent reply other threads:[~2020-11-02 14:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 14:42 [PATCH-for-5.2? 0/5] tests/acceptance: Only run tests tagged 'gating-ci' on GitLab CI Philippe Mathieu-Daudé
2020-11-02 14:42 ` [PATCH-for-5.2? 1/5] tests/acceptance: Restrict virtio_check_params tests to X86 target Philippe Mathieu-Daudé
2020-11-17 12:48 ` Philippe Mathieu-Daudé
2020-11-23 15:29 ` Willian Rampazzo
2020-11-02 14:42 ` [PATCH-for-5.2? 2/5] tests/acceptance: Restore MIPS Malta multicore tests Philippe Mathieu-Daudé
2020-11-03 6:27 ` Philippe Mathieu-Daudé
2020-11-02 14:42 ` Philippe Mathieu-Daudé [this message]
2020-11-03 2:12 ` [PATCH-for-5.2? 3/5] tests/acceptance: Skip incomplete virtio_version tests using '@skip' Philippe Mathieu-Daudé
2020-11-04 11:13 ` Thomas Huth
2020-11-04 11:27 ` Philippe Mathieu-Daudé
2020-11-04 11:45 ` Thomas Huth
2020-11-02 14:42 ` [RFC PATCH-for-5.2? 4/5] tests/acceptance: Only run tests tagged 'gating-ci' on GitLab CI Philippe Mathieu-Daudé
2020-11-02 14:59 ` Philippe Mathieu-Daudé
2020-11-02 16:12 ` Cleber Rosa
2021-10-25 14:06 ` Philippe Mathieu-Daudé
2020-11-02 14:42 ` [PATCH-for-5.2? 5/5] tests/acceptance: Let stable tests use the 'gating-ci' tag Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102144245.2134077-4-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.rikalo@syrmia.com \
--cc=antonynpavlov@gmail.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=chouteau@adacore.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=frederic.konrad@adacore.com \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mrolnik@gmail.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).