From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69A3C00A89 for ; Mon, 2 Nov 2020 15:16:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58F6921D40 for ; Mon, 2 Nov 2020 15:16:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cX49QiUj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58F6921D40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZbZ6-00023r-F1 for qemu-devel@archiver.kernel.org; Mon, 02 Nov 2020 10:16:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZbX6-0000FE-SM for qemu-devel@nongnu.org; Mon, 02 Nov 2020 10:14:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33273) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kZbX4-0006Ur-EM for qemu-devel@nongnu.org; Mon, 02 Nov 2020 10:14:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604330044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9IcAiwlKuinCUjaiK4nRdS92EyQ0a7uZDOZCZfu7eCg=; b=cX49QiUjGtlhkrDcvZptQZyF6v3sI6HtuulTLEm9qUtLkI91PZK7cQyRJlhTl6AQ8BLUZF gvRVd6WANFPfyiY3B9vvBA4EE4BNqxmkYKz4/WDurZaRg04gc7v7XWb4l4pyLY/sw9Qm13 qmiIBk9xwK9285ZX2hZzhbtHgd9MkkE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-1kHfmC_yMxy5ZjdZkDysGw-1; Mon, 02 Nov 2020 10:14:00 -0500 X-MC-Unique: 1kHfmC_yMxy5ZjdZkDysGw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B96441084C90; Mon, 2 Nov 2020 15:13:59 +0000 (UTC) Received: from work-vm (ovpn-114-142.ams2.redhat.com [10.36.114.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B98875C5BB; Mon, 2 Nov 2020 15:13:52 +0000 (UTC) Date: Mon, 2 Nov 2020 15:13:50 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH] virtiofsd: Seccomp: Add 'send' for syslog Message-ID: <20201102151350.GH3673@work-vm> References: <20201102150750.34565-1-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/02 03:02:24 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, amulmek1@in.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > On 11/2/20 4:07 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > On ppc it looks like syslog ends up using 'send' rather than 'sendto'. > > > > Reference: https://github.com/kata-containers/kata-containers/issues/1050 > > > > Reported-by: amulmek1@in.ibm.com > > Signed-off-by: Dr. David Alan Gilbert > > --- > > tools/virtiofsd/passthrough_seccomp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c > > index eb9af8265f..672fb72a31 100644 > > --- a/tools/virtiofsd/passthrough_seccomp.c > > +++ b/tools/virtiofsd/passthrough_seccomp.c > > @@ -118,6 +118,7 @@ static const int syscall_whitelist[] = { > > > > /* Syscalls used when --syslog is enabled */ > > static const int syscall_whitelist_syslog[] = { > > Is it worth restricting the syscall to POWER? > > #if defined(__powerpc64__) I don't think so, since it's legal for a libc to use either; so any other libc or architecture could choose either to use. Dave > > + SCMP_SYS(send), > > #endif > > > SCMP_SYS(sendto), > > }; > > > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK