From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Miklos Szeredi <mszeredi@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Max Reitz <mreitz@redhat.com>,
virtio-fs@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH v3 1/7] virtiofsd: Check FUSE_SUBMOUNTS
Date: Mon, 2 Nov 2020 17:18:53 +0100 [thread overview]
Message-ID: <20201102161859.156603-2-mreitz@redhat.com> (raw)
In-Reply-To: <20201102161859.156603-1-mreitz@redhat.com>
FUSE_SUBMOUNTS is a pure indicator by the kernel to signal that it
supports submounts. It does not check its state in the init reply, so
there is nothing for fuse_lowlevel.c to do but to check its existence
and copy it into fuse_conn_info.capable.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tools/virtiofsd/fuse_common.h | 7 +++++++
tools/virtiofsd/fuse_lowlevel.c | 3 +++
2 files changed, 10 insertions(+)
diff --git a/tools/virtiofsd/fuse_common.h b/tools/virtiofsd/fuse_common.h
index 686c42c0a5..5aee5193eb 100644
--- a/tools/virtiofsd/fuse_common.h
+++ b/tools/virtiofsd/fuse_common.h
@@ -352,6 +352,13 @@ struct fuse_file_info {
*/
#define FUSE_CAP_NO_OPENDIR_SUPPORT (1 << 24)
+/**
+ * Indicates that the kernel supports the FUSE_ATTR_SUBMOUNT flag.
+ *
+ * Setting (or unsetting) this flag in the `want` field has *no effect*.
+ */
+#define FUSE_CAP_SUBMOUNTS (1 << 27)
+
/**
* Ioctl flags
*
diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
index 4d1ba2925d..370222339b 100644
--- a/tools/virtiofsd/fuse_lowlevel.c
+++ b/tools/virtiofsd/fuse_lowlevel.c
@@ -1988,6 +1988,9 @@ static void do_init(fuse_req_t req, fuse_ino_t nodeid,
bufsize = max_bufsize;
}
}
+ if (arg->flags & FUSE_SUBMOUNTS) {
+ se->conn.capable |= FUSE_CAP_SUBMOUNTS;
+ }
#ifdef HAVE_SPLICE
#ifdef HAVE_VMSPLICE
se->conn.capable |= FUSE_CAP_SPLICE_WRITE | FUSE_CAP_SPLICE_MOVE;
--
2.26.2
next prev parent reply other threads:[~2020-11-02 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 16:18 [PATCH v3 0/7] virtiofsd: Announce submounts to the guest Max Reitz
2020-11-02 16:18 ` Max Reitz [this message]
2020-11-02 16:18 ` [PATCH v3 2/7] virtiofsd: Add attr_flags to fuse_entry_param Max Reitz
2020-11-02 16:18 ` [PATCH v3 3/7] meson.build: Check for statx() Max Reitz
2020-11-02 16:18 ` [PATCH v3 4/7] virtiofsd: Add mount ID to the lo_inode key Max Reitz
2020-11-02 16:18 ` [PATCH v3 5/7] virtiofsd: Announce sub-mount points Max Reitz
2020-11-03 8:10 ` Miklos Szeredi
2020-11-03 9:00 ` Max Reitz
2020-11-03 9:14 ` Miklos Szeredi
2020-11-02 16:18 ` [PATCH v3 6/7] tests/acceptance/boot_linux: Accept SSH pubkey Max Reitz
2020-11-02 16:18 ` [PATCH v3 7/7] tests/acceptance: Add virtiofs_submounts.py Max Reitz
2020-11-02 18:55 ` Eduardo Habkost
2020-11-03 8:13 ` [PATCH v3 0/7] virtiofsd: Announce submounts to the guest Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102161859.156603-2-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mszeredi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).