* [PATCH] virtiofsd: Fix the help message of posix lock
@ 2020-10-27 8:15 Jiachen Zhang
2020-10-27 8:42 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jiachen Zhang @ 2020-10-27 8:15 UTC (permalink / raw)
To: Dr . David Alan Gilbert, Stefan Hajnoczi; +Cc: Jiachen Zhang, qemu-devel
The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote
posix locks by default. But the --help message still says it is enabled
by default. So fix it to output no_posix_lock.
Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
---
tools/virtiofsd/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
index 85770d63f1..574dd09e91 100644
--- a/tools/virtiofsd/helper.c
+++ b/tools/virtiofsd/helper.c
@@ -161,7 +161,7 @@ void fuse_cmdline_help(void)
" allowed (default: 10)\n"
" -o posix_lock|no_posix_lock\n"
" enable/disable remote posix lock\n"
- " default: posix_lock\n"
+ " default: no_posix_lock\n"
" -o readdirplus|no_readdirplus\n"
" enable/disable readirplus\n"
" default: readdirplus except with "
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] virtiofsd: Fix the help message of posix lock
2020-10-27 8:15 [PATCH] virtiofsd: Fix the help message of posix lock Jiachen Zhang
@ 2020-10-27 8:42 ` Philippe Mathieu-Daudé
2020-10-27 18:33 ` Dr. David Alan Gilbert
2020-11-02 18:43 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-27 8:42 UTC (permalink / raw)
To: Jiachen Zhang, Dr . David Alan Gilbert, Stefan Hajnoczi; +Cc: qemu-devel
On 10/27/20 9:15 AM, Jiachen Zhang wrote:
> The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote
> posix locks by default. But the --help message still says it is enabled
> by default. So fix it to output no_posix_lock.
>
> Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tools/virtiofsd/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 85770d63f1..574dd09e91 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -161,7 +161,7 @@ void fuse_cmdline_help(void)
> " allowed (default: 10)\n"
> " -o posix_lock|no_posix_lock\n"
> " enable/disable remote posix lock\n"
> - " default: posix_lock\n"
> + " default: no_posix_lock\n"
> " -o readdirplus|no_readdirplus\n"
> " enable/disable readirplus\n"
> " default: readdirplus except with "
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtiofsd: Fix the help message of posix lock
2020-10-27 8:15 [PATCH] virtiofsd: Fix the help message of posix lock Jiachen Zhang
2020-10-27 8:42 ` Philippe Mathieu-Daudé
@ 2020-10-27 18:33 ` Dr. David Alan Gilbert
2020-11-02 18:43 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2020-10-27 18:33 UTC (permalink / raw)
To: Jiachen Zhang; +Cc: qemu-devel, Stefan Hajnoczi
* Jiachen Zhang (zhangjiachen.jaycee@bytedance.com) wrote:
> The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote
> posix locks by default. But the --help message still says it is enabled
> by default. So fix it to output no_posix_lock.
>
> Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Thanks!
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tools/virtiofsd/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 85770d63f1..574dd09e91 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -161,7 +161,7 @@ void fuse_cmdline_help(void)
> " allowed (default: 10)\n"
> " -o posix_lock|no_posix_lock\n"
> " enable/disable remote posix lock\n"
> - " default: posix_lock\n"
> + " default: no_posix_lock\n"
> " -o readdirplus|no_readdirplus\n"
> " enable/disable readirplus\n"
> " default: readdirplus except with "
> --
> 2.20.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtiofsd: Fix the help message of posix lock
2020-10-27 8:15 [PATCH] virtiofsd: Fix the help message of posix lock Jiachen Zhang
2020-10-27 8:42 ` Philippe Mathieu-Daudé
2020-10-27 18:33 ` Dr. David Alan Gilbert
@ 2020-11-02 18:43 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2020-11-02 18:43 UTC (permalink / raw)
To: Jiachen Zhang; +Cc: qemu-devel, Stefan Hajnoczi
* Jiachen Zhang (zhangjiachen.jaycee@bytedance.com) wrote:
> The commit 88fc107956a5812649e5918e0c092d3f78bb28ad disabled remote
> posix locks by default. But the --help message still says it is enabled
> by default. So fix it to output no_posix_lock.
>
> Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Thanks,
Queued
> ---
> tools/virtiofsd/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 85770d63f1..574dd09e91 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -161,7 +161,7 @@ void fuse_cmdline_help(void)
> " allowed (default: 10)\n"
> " -o posix_lock|no_posix_lock\n"
> " enable/disable remote posix lock\n"
> - " default: posix_lock\n"
> + " default: no_posix_lock\n"
> " -o readdirplus|no_readdirplus\n"
> " enable/disable readirplus\n"
> " default: readdirplus except with "
> --
> 2.20.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-02 18:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-27 8:15 [PATCH] virtiofsd: Fix the help message of posix lock Jiachen Zhang
2020-10-27 8:42 ` Philippe Mathieu-Daudé
2020-10-27 18:33 ` Dr. David Alan Gilbert
2020-11-02 18:43 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).