qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, peterx@redhat.com, philmd@redhat.com,
	zhangjiachen.jaycee@bytedance.com, mreitz@redhat.com
Cc: stefanha@redhat.com, quintela@redhat.com
Subject: [PULL 06/12] virtiofsd: Check FUSE_SUBMOUNTS
Date: Mon,  2 Nov 2020 19:56:51 +0000	[thread overview]
Message-ID: <20201102195657.219501-7-dgilbert@redhat.com> (raw)
In-Reply-To: <20201102195657.219501-1-dgilbert@redhat.com>

From: Max Reitz <mreitz@redhat.com>

FUSE_SUBMOUNTS is a pure indicator by the kernel to signal that it
supports submounts.  It does not check its state in the init reply, so
there is nothing for fuse_lowlevel.c to do but to check its existence
and copy it into fuse_conn_info.capable.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20201102161859.156603-2-mreitz@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tools/virtiofsd/fuse_common.h   | 7 +++++++
 tools/virtiofsd/fuse_lowlevel.c | 3 +++
 2 files changed, 10 insertions(+)

diff --git a/tools/virtiofsd/fuse_common.h b/tools/virtiofsd/fuse_common.h
index 686c42c0a5..5aee5193eb 100644
--- a/tools/virtiofsd/fuse_common.h
+++ b/tools/virtiofsd/fuse_common.h
@@ -352,6 +352,13 @@ struct fuse_file_info {
  */
 #define FUSE_CAP_NO_OPENDIR_SUPPORT (1 << 24)
 
+/**
+ * Indicates that the kernel supports the FUSE_ATTR_SUBMOUNT flag.
+ *
+ * Setting (or unsetting) this flag in the `want` field has *no effect*.
+ */
+#define FUSE_CAP_SUBMOUNTS (1 << 27)
+
 /**
  * Ioctl flags
  *
diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
index 4d1ba2925d..370222339b 100644
--- a/tools/virtiofsd/fuse_lowlevel.c
+++ b/tools/virtiofsd/fuse_lowlevel.c
@@ -1988,6 +1988,9 @@ static void do_init(fuse_req_t req, fuse_ino_t nodeid,
             bufsize = max_bufsize;
         }
     }
+    if (arg->flags & FUSE_SUBMOUNTS) {
+        se->conn.capable |= FUSE_CAP_SUBMOUNTS;
+    }
 #ifdef HAVE_SPLICE
 #ifdef HAVE_VMSPLICE
     se->conn.capable |= FUSE_CAP_SPLICE_WRITE | FUSE_CAP_SPLICE_MOVE;
-- 
2.28.0



  parent reply	other threads:[~2020-11-02 20:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 19:56 [PULL 00/12] migration queue Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 01/12] migration: Unify reset of last_rb on destination node when recover Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 02/12] migration: Postpone the kick of the fault thread after recover Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 03/12] virtiofsd: Seccomp: Add 'send' for syslog Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 04/12] tools/virtiofsd: Check vu_init() return value (CID 1435958) Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 05/12] virtiofsd: Fix the help message of posix lock Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` Dr. David Alan Gilbert (git) [this message]
2020-11-02 19:56 ` [PULL 07/12] virtiofsd: Add attr_flags to fuse_entry_param Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 08/12] meson.build: Check for statx() Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 09/12] virtiofsd: Add mount ID to the lo_inode key Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 10/12] virtiofsd: Announce sub-mount points Dr. David Alan Gilbert (git)
2020-11-03 10:24   ` Max Reitz
2020-11-03 10:29     ` Dr. David Alan Gilbert
2020-11-02 19:56 ` [PULL 11/12] tests/acceptance/boot_linux: Accept SSH pubkey Dr. David Alan Gilbert (git)
2020-11-02 19:56 ` [PULL 12/12] tests/acceptance: Add virtiofs_submounts.py Dr. David Alan Gilbert (git)
2020-11-03 10:37 ` [PULL 00/12] migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102195657.219501-7-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=zhangjiachen.jaycee@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).