* [PATCH] target/i386: tracing: format length values as hex
@ 2020-11-03 10:07 Dov Murik
2020-11-03 10:42 ` Philippe Mathieu-Daudé
2020-12-09 17:58 ` Dov Murik
0 siblings, 2 replies; 5+ messages in thread
From: Dov Murik @ 2020-11-03 10:07 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Dov Murik, Brijesh Singh, Eduardo Habkost,
Richard Henderson
Three trace events had a literal "0x" prefix but the 'len' values were
formatted in decimal base. Keep the prefix and format the numbers as
hex, as is usually the case for length of memory regions.
Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
---
target/i386/trace-events | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/i386/trace-events b/target/i386/trace-events
index 789c700d4a..65c9b0fdda 100644
--- a/target/i386/trace-events
+++ b/target/i386/trace-events
@@ -8,10 +8,10 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
# sev.c
kvm_sev_init(void) ""
-kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zu"
-kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zu"
+kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zx"
+kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zx"
kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
-kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64
+kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIx64
kvm_sev_launch_measurement(const char *value) "data %s"
kvm_sev_launch_finish(void) ""
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] target/i386: tracing: format length values as hex
2020-11-03 10:07 [PATCH] target/i386: tracing: format length values as hex Dov Murik
@ 2020-11-03 10:42 ` Philippe Mathieu-Daudé
2020-12-09 17:58 ` Dov Murik
1 sibling, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-03 10:42 UTC (permalink / raw)
To: Dov Murik, qemu-devel
Cc: Paolo Bonzini, Brijesh Singh, Eduardo Habkost, Richard Henderson
On 11/3/20 11:07 AM, Dov Murik wrote:
> Three trace events had a literal "0x" prefix but the 'len' values were
> formatted in decimal base. Keep the prefix and format the numbers as
> hex, as is usually the case for length of memory regions.
>
> Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
> ---
> target/i386/trace-events | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/i386: tracing: format length values as hex
2020-11-03 10:07 [PATCH] target/i386: tracing: format length values as hex Dov Murik
2020-11-03 10:42 ` Philippe Mathieu-Daudé
@ 2020-12-09 17:58 ` Dov Murik
2020-12-13 15:27 ` Laurent Vivier
1 sibling, 1 reply; 5+ messages in thread
From: Dov Murik @ 2020-12-09 17:58 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Brijesh Singh, Eduardo Habkost,
Richard Henderson
ping
Adding CC qemu-trivial.
This already got one R-b:
https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html
-Dov
On 03/11/2020 12:07, Dov Murik wrote:
> Three trace events had a literal "0x" prefix but the 'len' values were
> formatted in decimal base. Keep the prefix and format the numbers as
> hex, as is usually the case for length of memory regions.
>
> Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
> ---
> target/i386/trace-events | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/i386/trace-events b/target/i386/trace-events
> index 789c700d4a..65c9b0fdda 100644
> --- a/target/i386/trace-events
> +++ b/target/i386/trace-events
> @@ -8,10 +8,10 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
>
> # sev.c
> kvm_sev_init(void) ""
> -kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zu"
> -kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zu"
> +kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zx"
> +kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zx"
> kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
> kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
> -kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64
> +kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIx64
> kvm_sev_launch_measurement(const char *value) "data %s"
> kvm_sev_launch_finish(void) ""
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/i386: tracing: format length values as hex
2020-12-09 17:58 ` Dov Murik
@ 2020-12-13 15:27 ` Laurent Vivier
2020-12-13 16:03 ` Laurent Vivier
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Vivier @ 2020-12-13 15:27 UTC (permalink / raw)
To: Dov Murik, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Brijesh Singh, Eduardo Habkost,
Richard Henderson
Le 09/12/2020 à 18:58, Dov Murik a écrit :
> ping
>
> Adding CC qemu-trivial.
>
> This already got one R-b:
> https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html
>
> -Dov
>
>
> On 03/11/2020 12:07, Dov Murik wrote:
>> Three trace events had a literal "0x" prefix but the 'len' values were
>> formatted in decimal base. Keep the prefix and format the numbers as
>> hex, as is usually the case for length of memory regions.
>>
>> Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
>> ---
>> target/i386/trace-events | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/target/i386/trace-events b/target/i386/trace-events
>> index 789c700d4a..65c9b0fdda 100644
>> --- a/target/i386/trace-events
>> +++ b/target/i386/trace-events
>> @@ -8,10 +8,10 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
>>
>> # sev.c
>> kvm_sev_init(void) ""
>> -kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zu"
>> -kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zu"
>> +kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zx"
>> +kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zx"
>> kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
>> kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
>> -kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64
>> +kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIx64
>> kvm_sev_launch_measurement(const char *value) "data %s"
>> kvm_sev_launch_finish(void) ""
>>
>
Applied to my linux-user-for-6.0 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/i386: tracing: format length values as hex
2020-12-13 15:27 ` Laurent Vivier
@ 2020-12-13 16:03 ` Laurent Vivier
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2020-12-13 16:03 UTC (permalink / raw)
To: Dov Murik, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Brijesh Singh, Eduardo Habkost,
Richard Henderson
Le 13/12/2020 à 16:27, Laurent Vivier a écrit :
> Le 09/12/2020 à 18:58, Dov Murik a écrit :
>> ping
>>
>> Adding CC qemu-trivial.
>>
>> This already got one R-b:
>> https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html
>>
>> -Dov
>>
>>
>> On 03/11/2020 12:07, Dov Murik wrote:
>>> Three trace events had a literal "0x" prefix but the 'len' values were
>>> formatted in decimal base. Keep the prefix and format the numbers as
>>> hex, as is usually the case for length of memory regions.
>>>
>>> Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
>>> ---
>>> target/i386/trace-events | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/target/i386/trace-events b/target/i386/trace-events
>>> index 789c700d4a..65c9b0fdda 100644
>>> --- a/target/i386/trace-events
>>> +++ b/target/i386/trace-events
>>> @@ -8,10 +8,10 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
>>>
>>> # sev.c
>>> kvm_sev_init(void) ""
>>> -kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zu"
>>> -kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zu"
>>> +kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zx"
>>> +kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zx"
>>> kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
>>> kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
>>> -kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64
>>> +kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIx64
>>> kvm_sev_launch_measurement(const char *value) "data %s"
>>> kvm_sev_launch_finish(void) ""
>>>
>>
>
> Applied to my linux-user-for-6.0 branch.
s/linux-user-for-6.0/trivial-patches/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-13 16:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-03 10:07 [PATCH] target/i386: tracing: format length values as hex Dov Murik
2020-11-03 10:42 ` Philippe Mathieu-Daudé
2020-12-09 17:58 ` Dov Murik
2020-12-13 15:27 ` Laurent Vivier
2020-12-13 16:03 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).