From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
qemu-trivial@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Dov Murik" <dovmurik@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PATCH-for-5.2 1/4] hw/display/cirrus_vga: Remove debugging code commented out
Date: Tue, 3 Nov 2020 12:25:55 +0100 [thread overview]
Message-ID: <20201103112558.2554390-2-philmd@redhat.com> (raw)
In-Reply-To: <20201103112558.2554390-1-philmd@redhat.com>
Commit ec87f206d70 ("cirrus: replace debug printf with trace points")
forgot to remove this code once replaced. Do it now.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/display/cirrus_vga.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index 722b9e7004c..e14096deb46 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -2532,9 +2532,6 @@ static uint64_t cirrus_vga_ioport_read(void *opaque, hwaddr addr,
case 0x3c5:
val = cirrus_vga_read_sr(c);
break;
-#ifdef DEBUG_VGA_REG
- printf("vga: read SR%x = 0x%02x\n", s->sr_index, val);
-#endif
break;
case 0x3c6:
val = cirrus_read_hidden_dac(c);
@@ -2560,9 +2557,6 @@ static uint64_t cirrus_vga_ioport_read(void *opaque, hwaddr addr,
break;
case 0x3cf:
val = cirrus_vga_read_gr(c, s->gr_index);
-#ifdef DEBUG_VGA_REG
- printf("vga: read GR%x = 0x%02x\n", s->gr_index, val);
-#endif
break;
case 0x3b4:
case 0x3d4:
@@ -2571,9 +2565,6 @@ static uint64_t cirrus_vga_ioport_read(void *opaque, hwaddr addr,
case 0x3b5:
case 0x3d5:
val = cirrus_vga_read_cr(c, s->cr_index);
-#ifdef DEBUG_VGA_REG
- printf("vga: read CR%x = 0x%02x\n", s->cr_index, val);
-#endif
break;
case 0x3ba:
case 0x3da:
@@ -2645,9 +2636,6 @@ static void cirrus_vga_ioport_write(void *opaque, hwaddr addr, uint64_t val,
s->sr_index = val;
break;
case 0x3c5:
-#ifdef DEBUG_VGA_REG
- printf("vga: write SR%x = 0x%02" PRIu64 "\n", s->sr_index, val);
-#endif
cirrus_vga_write_sr(c, val);
break;
case 0x3c6:
@@ -2670,9 +2658,6 @@ static void cirrus_vga_ioport_write(void *opaque, hwaddr addr, uint64_t val,
s->gr_index = val;
break;
case 0x3cf:
-#ifdef DEBUG_VGA_REG
- printf("vga: write GR%x = 0x%02" PRIu64 "\n", s->gr_index, val);
-#endif
cirrus_vga_write_gr(c, s->gr_index, val);
break;
case 0x3b4:
@@ -2681,9 +2666,6 @@ static void cirrus_vga_ioport_write(void *opaque, hwaddr addr, uint64_t val,
break;
case 0x3b5:
case 0x3d5:
-#ifdef DEBUG_VGA_REG
- printf("vga: write CR%x = 0x%02"PRIu64"\n", s->cr_index, val);
-#endif
cirrus_vga_write_cr(c, val);
break;
case 0x3ba:
--
2.26.2
next prev parent reply other threads:[~2020-11-03 11:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 11:25 [PATCH-for-5.2 0/4] misc: Trivial format string fixes Philippe Mathieu-Daudé
2020-11-03 11:25 ` Philippe Mathieu-Daudé [this message]
2020-11-03 12:42 ` [PATCH-for-5.2 1/4] hw/display/cirrus_vga: Remove debugging code commented out Dr. David Alan Gilbert
2020-11-03 11:25 ` [PATCH-for-5.2 2/4] hw/display/cirrus_vga: Fix hexadecimal format string specifier Philippe Mathieu-Daudé
2020-11-03 12:45 ` Dr. David Alan Gilbert
2020-11-09 14:29 ` Philippe Mathieu-Daudé
2020-11-03 11:25 ` [PATCH-for-5.2 3/4] hw/ppc/spapr_tpm_proxy: " Philippe Mathieu-Daudé
2020-11-03 11:39 ` David Gibson
2020-11-09 14:28 ` Philippe Mathieu-Daudé
2020-11-23 6:15 ` David Gibson
2020-11-03 11:40 ` Greg Kurz
2020-11-03 11:25 ` [PATCH-for-5.2 4/4] migration/ram: " Philippe Mathieu-Daudé
2020-11-03 12:46 ` Dr. David Alan Gilbert
2020-11-09 14:30 ` Philippe Mathieu-Daudé
2020-11-09 15:01 ` Dr. David Alan Gilbert
2020-11-12 14:03 ` Dr. David Alan Gilbert
2020-11-03 13:58 ` [PATCH-for-5.2 0/4] misc: Trivial format string fixes Dov Murik
2020-11-03 14:03 ` Dov Murik
2020-11-03 14:28 ` Philippe Mathieu-Daudé
2020-11-03 15:20 ` Greg Kurz
2020-11-03 15:44 ` Philippe Mathieu-Daudé
2020-11-03 15:26 ` Dov Murik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103112558.2554390-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=dovmurik@linux.vnet.ibm.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).