From: Cornelia Huck <cohuck@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Matthew Rosato" <mjrosato@linux.ibm.com>
Subject: Re: [PULL v3 23/32] s390x/pci: Add routine to get the vfio dma available count
Date: Tue, 3 Nov 2020 12:15:10 +0100 [thread overview]
Message-ID: <20201103121510.35d26fec.cohuck@redhat.com> (raw)
In-Reply-To: <2d6befc5-0516-5ff0-7498-0f4deca92738@redhat.com>
On Tue, 3 Nov 2020 12:08:20 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> On 11/3/20 11:45 AM, Cornelia Huck wrote:
> > On Tue, 3 Nov 2020 06:49:13 +0100
> > Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> >
> >> Hi Matthew,
> >>
> >> On 11/1/20 10:02 PM, Alex Williamson wrote:
> >>> From: Matthew Rosato <mjrosato@linux.ibm.com>
> >>>
> >>> Create new files for separating out vfio-specific work for s390
> >>> pci. Add the first such routine, which issues VFIO_IOMMU_GET_INFO
> >>> ioctl to collect the current dma available count.
> >>>
> >>> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> >>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> >>> [aw: Fix non-Linux build with CONFIG_LINUX]
> >>> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> >>> ---
> >>> hw/s390x/meson.build | 1 +
> >>> hw/s390x/s390-pci-vfio.c | 54 ++++++++++++++++++++++++++++++++++++++
> >>> include/hw/s390x/s390-pci-vfio.h | 24 +++++++++++++++++
> >>> 3 files changed, 79 insertions(+)
> >>> create mode 100644 hw/s390x/s390-pci-vfio.c
> >>> create mode 100644 include/hw/s390x/s390-pci-vfio.h
> >>>
> >>> diff --git a/hw/s390x/meson.build b/hw/s390x/meson.build
> >>> index 948ceae7a7b3..f4663a835514 100644
> >>> --- a/hw/s390x/meson.build
> >>> +++ b/hw/s390x/meson.build
> >>> @@ -27,6 +27,7 @@ s390x_ss.add(when: 'CONFIG_KVM', if_true: files(
> >>> ))
> >>> s390x_ss.add(when: 'CONFIG_S390_CCW_VIRTIO', if_true: files('s390-virtio-ccw.c'))
> >>> s390x_ss.add(when: 'CONFIG_TERMINAL3270', if_true: files('3270-ccw.c'))
> >>> +s390x_ss.add(when: 'CONFIG_LINUX', if_true: files('s390-pci-vfio.c'))
> >
> > I think we need s/CONFIG_LINUX/CONFIG_VFIO/ here.
>
> With your change:
>
> hw/s390x/s390-pci-bus.c:1079: undefined reference to
> `s390_pci_end_dma_count'
> hw/s390x/s390-pci-bus.c:1019: undefined reference to
> `s390_pci_start_dma_count'
> hw/s390x/s390-pci-bus.c:1021: undefined reference to `s390_pci_get_clp_info'
>
> Do we need stubs instead?
>
We do have stubs; we just need them to be ifdeffed with CONFIG_VFIO
instead of CONFIG_LINUX. Currently preparing a proper patch.
next prev parent reply other threads:[~2020-11-03 11:16 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 20:58 [PULL v3 00/32] VFIO updates 2020-11-01 (for QEMU 5.2 soft-freeze) Alex Williamson
2020-11-01 20:59 ` [PULL v3 01/32] vfio: Add function to unmap VFIO region Alex Williamson
2020-11-01 20:59 ` [PULL v3 02/32] vfio: Add vfio_get_object callback to VFIODeviceOps Alex Williamson
2020-11-01 20:59 ` [PULL v3 03/32] vfio: Add save and load functions for VFIO PCI devices Alex Williamson
2020-11-01 20:59 ` [PULL v3 04/32] vfio: Add migration region initialization and finalize function Alex Williamson
2020-11-05 23:55 ` Peter Maydell
2020-11-06 0:32 ` Alex Williamson
2020-11-01 20:59 ` [PULL v3 05/32] vfio: Add VM state change handler to know state of VM Alex Williamson
2020-11-01 20:59 ` [PULL v3 06/32] vfio: Add migration state change notifier Alex Williamson
2020-11-01 21:00 ` [PULL v3 07/32] vfio: Register SaveVMHandlers for VFIO device Alex Williamson
2020-11-01 21:00 ` [PULL v3 08/32] vfio: Add save state functions to SaveVMHandlers Alex Williamson
2020-11-01 21:00 ` [PULL v3 09/32] vfio: Add load " Alex Williamson
2020-11-01 21:00 ` [PULL v3 10/32] memory: Set DIRTY_MEMORY_MIGRATION when IOMMU is enabled Alex Williamson
2020-11-01 21:00 ` [PULL v3 11/32] vfio: Get migration capability flags for container Alex Williamson
2020-12-15 8:17 ` zhukeqian
2020-11-01 21:00 ` [PULL v3 12/32] vfio: Add function to start and stop dirty pages tracking Alex Williamson
2020-11-01 21:01 ` [PULL v3 13/32] vfio: Add vfio_listener_log_sync to mark dirty pages Alex Williamson
2020-11-01 21:01 ` [PULL v3 14/32] vfio: Dirty page tracking when vIOMMU is enabled Alex Williamson
2020-11-01 21:01 ` [PULL v3 15/32] vfio: Add ioctl to get dirty pages bitmap during dma unmap Alex Williamson
2020-12-15 8:06 ` zhukeqian
2020-11-01 21:01 ` [PULL v3 16/32] vfio: Make vfio-pci device migration capable Alex Williamson
2020-11-01 21:01 ` [PULL v3 17/32] qapi: Add VFIO devices migration stats in Migration stats Alex Williamson
2020-11-01 21:01 ` [PULL v3 18/32] update-linux-headers: Add vfio_zdev.h Alex Williamson
2020-11-01 21:01 ` [PULL v3 19/32] linux-headers: update against 5.10-rc1 Alex Williamson
2020-11-01 21:01 ` [PULL v3 20/32] s390x/pci: Move header files to include/hw/s390x Alex Williamson
2020-11-01 21:02 ` [PULL v3 21/32] vfio: Create shared routine for scanning info capabilities Alex Williamson
2020-11-01 21:02 ` [PULL v3 22/32] vfio: Find DMA available capability Alex Williamson
2020-11-01 21:02 ` [PULL v3 23/32] s390x/pci: Add routine to get the vfio dma available count Alex Williamson
2020-11-03 5:49 ` Philippe Mathieu-Daudé
2020-11-03 10:45 ` Cornelia Huck
2020-11-03 10:57 ` Philippe Mathieu-Daudé
2020-11-03 11:08 ` Philippe Mathieu-Daudé
2020-11-03 11:15 ` Cornelia Huck [this message]
2020-11-01 21:02 ` [PULL v3 24/32] s390x/pci: Honor DMA limits set by vfio Alex Williamson
2020-11-01 21:02 ` [PULL v3 25/32] s390x/pci: create a header dedicated to PCI CLP Alex Williamson
2020-11-01 21:02 ` [PULL v3 26/32] s390x/pci: use a PCI Group structure Alex Williamson
2020-11-17 11:43 ` Cornelia Huck
2020-11-17 11:55 ` Philippe Mathieu-Daudé
2020-11-17 12:06 ` Cornelia Huck
2020-11-17 12:09 ` Philippe Mathieu-Daudé
2020-11-01 21:02 ` [PULL v3 27/32] s390x/pci: clean up s390 PCI groups Alex Williamson
2020-11-01 21:03 ` [PULL v3 28/32] s390x/pci: use a PCI Function structure Alex Williamson
2020-11-01 21:03 ` [PULL v3 29/32] vfio: Add routine for finding VFIO_DEVICE_GET_INFO capabilities Alex Williamson
2020-11-01 21:03 ` [PULL v3 30/32] s390x/pci: get zPCI function info from host Alex Williamson
2020-11-01 21:03 ` [PULL v3 31/32] hw/vfio: Use lock guard macros Alex Williamson
2020-11-01 21:03 ` [PULL v3 32/32] vfio: fix incorrect print type Alex Williamson
2020-11-02 10:57 ` [PULL v3 00/32] VFIO updates 2020-11-01 (for QEMU 5.2 soft-freeze) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103121510.35d26fec.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).