From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0BEC388F7 for ; Tue, 3 Nov 2020 12:45:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B511B22243 for ; Tue, 3 Nov 2020 12:45:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mq/oHWpT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B511B22243 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZvgd-0000h1-Q7 for qemu-devel@archiver.kernel.org; Tue, 03 Nov 2020 07:45:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZveo-0008CC-7J for qemu-devel@nongnu.org; Tue, 03 Nov 2020 07:43:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:28505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kZvei-0007ja-RH for qemu-devel@nongnu.org; Tue, 03 Nov 2020 07:43:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604407399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rn9gc3ibgYP5yyzdUD+0i+5y3fmAU2EWC7mUiX0WCqI=; b=Mq/oHWpTqx+DKBJd+vlEXaGGLmwefILNPBWxLA/FqWM/ONSBiq3BTCK/6ZzYNBtDsI51G+ 6FW5kqJRR9iDgwSbrO6DCtcubQpsYXFaLV2OHP9592pVh4NawBYUsEcSKQeFWCDgL1radQ 25zuXmySSHsum6++MYYgA/apVACnkh4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-73-JUVbyhckPJ2a6iBNBY_7fQ-1; Tue, 03 Nov 2020 07:43:17 -0500 X-MC-Unique: JUVbyhckPJ2a6iBNBY_7fQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 40C561009E25; Tue, 3 Nov 2020 12:43:16 +0000 (UTC) Received: from work-vm (ovpn-115-84.ams2.redhat.com [10.36.115.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFEE060BF1; Tue, 3 Nov 2020 12:42:58 +0000 (UTC) Date: Tue, 3 Nov 2020 12:42:55 +0000 From: "Dr. David Alan Gilbert" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH-for-5.2 1/4] hw/display/cirrus_vga: Remove debugging code commented out Message-ID: <20201103124255.GE3566@work-vm> References: <20201103112558.2554390-1-philmd@redhat.com> <20201103112558.2554390-2-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201103112558.2554390-2-philmd@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , qemu-devel@nongnu.org, Dov Murik , qemu-ppc@nongnu.org, Gerd Hoffmann , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Philippe Mathieu-Daudé (philmd@redhat.com) wrote: > Commit ec87f206d70 ("cirrus: replace debug printf with trace points") > forgot to remove this code once replaced. Do it now. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Dr. David Alan Gilbert > --- > hw/display/cirrus_vga.c | 18 ------------------ > 1 file changed, 18 deletions(-) > > diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c > index 722b9e7004c..e14096deb46 100644 > --- a/hw/display/cirrus_vga.c > +++ b/hw/display/cirrus_vga.c > @@ -2532,9 +2532,6 @@ static uint64_t cirrus_vga_ioport_read(void *opaque, hwaddr addr, > case 0x3c5: > val = cirrus_vga_read_sr(c); > break; > -#ifdef DEBUG_VGA_REG > - printf("vga: read SR%x = 0x%02x\n", s->sr_index, val); > -#endif > break; > case 0x3c6: > val = cirrus_read_hidden_dac(c); > @@ -2560,9 +2557,6 @@ static uint64_t cirrus_vga_ioport_read(void *opaque, hwaddr addr, > break; > case 0x3cf: > val = cirrus_vga_read_gr(c, s->gr_index); > -#ifdef DEBUG_VGA_REG > - printf("vga: read GR%x = 0x%02x\n", s->gr_index, val); > -#endif > break; > case 0x3b4: > case 0x3d4: > @@ -2571,9 +2565,6 @@ static uint64_t cirrus_vga_ioport_read(void *opaque, hwaddr addr, > case 0x3b5: > case 0x3d5: > val = cirrus_vga_read_cr(c, s->cr_index); > -#ifdef DEBUG_VGA_REG > - printf("vga: read CR%x = 0x%02x\n", s->cr_index, val); > -#endif > break; > case 0x3ba: > case 0x3da: > @@ -2645,9 +2636,6 @@ static void cirrus_vga_ioport_write(void *opaque, hwaddr addr, uint64_t val, > s->sr_index = val; > break; > case 0x3c5: > -#ifdef DEBUG_VGA_REG > - printf("vga: write SR%x = 0x%02" PRIu64 "\n", s->sr_index, val); > -#endif > cirrus_vga_write_sr(c, val); > break; > case 0x3c6: > @@ -2670,9 +2658,6 @@ static void cirrus_vga_ioport_write(void *opaque, hwaddr addr, uint64_t val, > s->gr_index = val; > break; > case 0x3cf: > -#ifdef DEBUG_VGA_REG > - printf("vga: write GR%x = 0x%02" PRIu64 "\n", s->gr_index, val); > -#endif > cirrus_vga_write_gr(c, s->gr_index, val); > break; > case 0x3b4: > @@ -2681,9 +2666,6 @@ static void cirrus_vga_ioport_write(void *opaque, hwaddr addr, uint64_t val, > break; > case 0x3b5: > case 0x3d5: > -#ifdef DEBUG_VGA_REG > - printf("vga: write CR%x = 0x%02"PRIu64"\n", s->cr_index, val); > -#endif > cirrus_vga_write_cr(c, val); > break; > case 0x3ba: > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK