From: Igor Mammedov <imammedo@redhat.com>
To: Xinhao Zhang <zhangxinhao1@huawei.com>
Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
alex.chen@huawei.com, dengkai1@huawei.com
Subject: Re: [PATCH 3/3] hw/acpi : add spaces around operator
Date: Tue, 3 Nov 2020 13:28:48 +0100 [thread overview]
Message-ID: <20201103132848.0872850d@redhat.com> (raw)
In-Reply-To: <20201103102634.273021-3-zhangxinhao1@huawei.com>
On Tue, 3 Nov 2020 18:26:34 +0800
Xinhao Zhang <zhangxinhao1@huawei.com> wrote:
> Fix code style. Operator needs spaces both sides.
>
> Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
> Signed-off-by: Kai Deng <dengkai1@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/acpi/pcihp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
> index 32ae8b2c0a..17c32e0ffd 100644
> --- a/hw/acpi/pcihp.c
> +++ b/hw/acpi/pcihp.c
> @@ -400,7 +400,7 @@ void acpi_pcihp_init(Object *owner, AcpiPciHpState *s, PCIBus *root_bus,
> s->io_len = ACPI_PCIHP_SIZE;
> s->io_base = ACPI_PCIHP_ADDR;
>
> - s->root= root_bus;
> + s->root = root_bus;
> s->legacy_piix = !bridges_enabled;
>
> memory_region_init_io(&s->io, owner, &acpi_pcihp_io_ops, s,
next prev parent reply other threads:[~2020-11-03 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 10:26 [PATCH 1/3] hw/acpi : Don't use '#' flag of printf format Xinhao Zhang
2020-11-03 10:26 ` [PATCH 2/3] hw/acpi : add space before the open parenthesis '(' Xinhao Zhang
2020-11-03 12:28 ` Igor Mammedov
2020-11-03 10:26 ` [PATCH 3/3] hw/acpi : add spaces around operator Xinhao Zhang
2020-11-03 12:28 ` Igor Mammedov [this message]
2020-11-03 12:27 ` [PATCH 1/3] hw/acpi : Don't use '#' flag of printf format Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103132848.0872850d@redhat.com \
--to=imammedo@redhat.com \
--cc=alex.chen@huawei.com \
--cc=dengkai1@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zhangxinhao1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).