From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9766C388F7 for ; Tue, 3 Nov 2020 12:36:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05E09208B6 for ; Tue, 3 Nov 2020 12:36:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YZyNTNlL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05E09208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZvYP-0002rc-0N for qemu-devel@archiver.kernel.org; Tue, 03 Nov 2020 07:36:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZvSJ-00044N-MX for qemu-devel@nongnu.org; Tue, 03 Nov 2020 07:30:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kZvSH-0003EN-KW for qemu-devel@nongnu.org; Tue, 03 Nov 2020 07:30:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604406629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zvlTrtKCbUUqX04j5vchgIGuywzZHvanTd77JlGCRWw=; b=YZyNTNlLKdOQ4Gu4F5FG84lhIIHXuu8Ok0V66l8fsDaMmb8JznqPdRu+/oMTjkCi8d0Opd t2NqWjkhMy2C38MvxRB0z5bW8O98C4WXh4o2uDPLOgR7WRBBk1J51rOruzMcXElyWHjkxB 3vpNdz5flXPAeQwUmSVJ+tz5z5/9vGo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-9zls6QyIPEarTyTORyB--g-1; Tue, 03 Nov 2020 07:30:27 -0500 X-MC-Unique: 9zls6QyIPEarTyTORyB--g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82F47100746B for ; Tue, 3 Nov 2020 12:30:26 +0000 (UTC) Received: from localhost (unknown [10.40.208.69]) by smtp.corp.redhat.com (Postfix) with ESMTP id 534365B4D4; Tue, 3 Nov 2020 12:30:25 +0000 (UTC) Date: Tue, 3 Nov 2020 13:30:23 +0100 From: Igor Mammedov To: Eduardo Habkost Subject: Re: [PATCH 10/20] memfd: Remove unnecessary prefix from error message Message-ID: <20201103133023.6d7a5241@redhat.com> In-Reply-To: <20201030202131.796967-11-ehabkost@redhat.com> References: <20201030202131.796967-1-ehabkost@redhat.com> <20201030202131.796967-11-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 30 Oct 2020 16:21:21 -0400 Eduardo Habkost wrote: > object_property_parse() will add a > "Property '.' can't take value ''" > prefix automatically for us. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: Eduardo Habkost > Cc: Igor Mammedov > Cc: qemu-devel@nongnu.org > --- > backends/hostmem-memfd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c > index e5626d4330..05cf743fe8 100644 > --- a/backends/hostmem-memfd.c > +++ b/backends/hostmem-memfd.c > @@ -87,8 +87,7 @@ memfd_backend_set_hugetlbsize(Object *obj, Visitor *v, const char *name, > return; > } > if (!value) { > - error_setg(errp, "Property '%s.%s' doesn't take value '%" PRIu64 "'", > - object_get_typename(obj), name, value); > + error_setg(errp, "hugetlbsize can't be zero"); > return; > } > m->hugetlbsize = value;