qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PULL 09/11] char-socket: Fix qemu_chr_socket_address() for abstract sockets
Date: Tue,  3 Nov 2020 14:02:23 +0000	[thread overview]
Message-ID: <20201103140225.496776-10-berrange@redhat.com> (raw)
In-Reply-To: <20201103140225.496776-1-berrange@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket
support" neglected to update qemu_chr_socket_address().  It shows
shows neither @abstract nor @tight.  Fix that.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 chardev/char-socket.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index 1ee5a8c295..27a2954f47 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -443,10 +443,22 @@ static char *qemu_chr_socket_address(SocketChardev *s, const char *prefix)
                                s->is_listen ? ",server" : "");
         break;
     case SOCKET_ADDRESS_TYPE_UNIX:
-        return g_strdup_printf("%sunix:%s%s", prefix,
-                               s->addr->u.q_unix.path,
+    {
+        const char *tight = "", *abstract = "";
+        UnixSocketAddress *sa = &s->addr->u.q_unix;
+
+        if (sa->has_abstract && sa->abstract) {
+            abstract = ",abstract";
+            if (sa->has_tight && sa->tight) {
+                tight = ",tight";
+            }
+        }
+
+        return g_strdup_printf("%sunix:%s%s%s%s", prefix, sa->path,
+                               abstract, tight,
                                s->is_listen ? ",server" : "");
         break;
+    }
     case SOCKET_ADDRESS_TYPE_FD:
         return g_strdup_printf("%sfd:%s%s", prefix, s->addr->u.fd.str,
                                s->is_listen ? ",server" : "");
-- 
2.28.0



  parent reply	other threads:[~2020-11-03 14:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 14:02 [PULL 00/11] Sock next patches Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 01/11] test-util-sockets: Plug file descriptor leak Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 02/11] test-util-sockets: Correct to set has_abstract, has_tight Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 03/11] test-util-sockets: Clean up SocketAddress construction Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 04/11] test-util-sockets: Factor out test_socket_unix_abstract_one() Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 05/11] test-util-sockets: Synchronize properly, don't sleep(1) Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 06/11] test-util-sockets: Test the complete abstract socket matrix Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 07/11] sockets: Fix default of UnixSocketAddress member @tight Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 08/11] sockets: Fix socket_sockaddr_to_address_unix() for abstract sockets Daniel P. Berrangé
2020-11-03 14:02 ` Daniel P. Berrangé [this message]
2020-11-03 14:02 ` [PULL 10/11] sockets: Bypass "replace empty @path" for abstract unix sockets Daniel P. Berrangé
2020-11-03 14:02 ` [PULL 11/11] sockets: Make abstract UnixSocketAddress depend on CONFIG_LINUX Daniel P. Berrangé
2020-11-03 15:35 ` [PULL 00/11] Sock next patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103140225.496776-10-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).