From: Kevin Wolf <kwolf@redhat.com>
To: AlexChen <alex.chen@huawei.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
zhang.zhanghailiang@huawei.com, QEMU <qemu-devel@nongnu.org>,
qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH V2] block/vvfat: Fix bad printf format specifiers
Date: Tue, 3 Nov 2020 15:06:57 +0100 [thread overview]
Message-ID: <20201103140657.GD5509@merkur.fritz.box> (raw)
In-Reply-To: <5FA12620.6030705@huawei.com>
Am 03.11.2020 um 10:42 hat AlexChen geschrieben:
> We should use printf format specifier "%u" instead of "%d" for
> argument of type "unsigned int".
> In addition, fix two error format problems found by checkpatch.pl:
> ERROR: space required after that ',' (ctx:VxV)
> + fprintf(stderr,"%s attributes=0x%02x begin=%u size=%d\n",
> ^
> ERROR: line over 90 characters
> + fprintf(stderr, "%d, %s (%u, %d)\n", i, commit->path ? commit->path : "(null)", commit->param.rename.cluster, commit->action);
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Alex Chen <alex.chen@huawei.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2020-11-03 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 9:42 [PATCH V2] block/vvfat: Fix bad printf format specifiers AlexChen
2020-11-03 14:06 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103140657.GD5509@merkur.fritz.box \
--to=kwolf@redhat.com \
--cc=alex.chen@huawei.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).