From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C69C388F9 for ; Tue, 3 Nov 2020 14:13:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67C2022226 for ; Tue, 3 Nov 2020 14:13:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I+BA1WJq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67C2022226 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZx4G-0002MG-Bp for qemu-devel@archiver.kernel.org; Tue, 03 Nov 2020 09:13:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZwxr-0003QB-C6 for qemu-devel@nongnu.org; Tue, 03 Nov 2020 09:07:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36171) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kZwxm-0004lQ-N8 for qemu-devel@nongnu.org; Tue, 03 Nov 2020 09:07:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604412425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d/WqzCSGXJ+A5Qk4+03iMLobXja4XoZVBskFYbcwRQk=; b=I+BA1WJqRitAJSoGj3tmEh3aKlD6HYwwPHaIo16OC3qVdGa4J2JHR6X5yLdzzy9bA0aH8m z4d+D4owLdtvSM9I52gdIbra+nMeldfKxkYISM0fYqg4ew2bpeTNcv8x9bfIY8feRFQLJP /O5JffPcsYmXpcrKFb0bQPxixPkdJf8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-uznlF40KO2iuiYwNuiNDLQ-1; Tue, 03 Nov 2020 09:07:01 -0500 X-MC-Unique: uznlF40KO2iuiYwNuiNDLQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E3FC100738B; Tue, 3 Nov 2020 14:07:00 +0000 (UTC) Received: from merkur.fritz.box (ovpn-113-164.ams2.redhat.com [10.36.113.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C5BDD6266E; Tue, 3 Nov 2020 14:06:58 +0000 (UTC) Date: Tue, 3 Nov 2020 15:06:57 +0100 From: Kevin Wolf To: AlexChen Subject: Re: [PATCH V2] block/vvfat: Fix bad printf format specifiers Message-ID: <20201103140657.GD5509@merkur.fritz.box> References: <5FA12620.6030705@huawei.com> MIME-Version: 1.0 In-Reply-To: <5FA12620.6030705@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , zhang.zhanghailiang@huawei.com, QEMU , qemu-block@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 03.11.2020 um 10:42 hat AlexChen geschrieben: > We should use printf format specifier "%u" instead of "%d" for > argument of type "unsigned int". > In addition, fix two error format problems found by checkpatch.pl: > ERROR: space required after that ',' (ctx:VxV) > + fprintf(stderr,"%s attributes=0x%02x begin=%u size=%d\n", > ^ > ERROR: line over 90 characters > + fprintf(stderr, "%d, %s (%u, %d)\n", i, commit->path ? commit->path : "(null)", commit->param.rename.cluster, commit->action); > > Reported-by: Euler Robot > Signed-off-by: Alex Chen Thanks, applied to the block branch. Kevin