* [PATCH] configure: fix gio_libs reference
@ 2020-11-03 14:51 Bruce Rogers
2020-11-03 15:00 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Bruce Rogers @ 2020-11-03 14:51 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, Bruce Rogers, philmd, pbonzini
The gio library detection code no longer works, due to a missing $ in
front of the gio_libs reference. Make the string be $gio_libs.
Fixes: 76346b6264a ("configure: Test that gio libs from pkg-config
work")
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 2c3c69f118..bc06aa81e5 100755
--- a/configure
+++ b/configure
@@ -3499,7 +3499,7 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
# with pkg-config --static --libs data for gio-2.0 that is missing
# -lblkid and will give a link error.
write_c_skeleton
- if compile_prog "" "gio_libs" ; then
+ if compile_prog "" "$gio_libs" ; then
gio=yes
else
gio=no
--
2.29.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] configure: fix gio_libs reference
2020-11-03 14:51 [PATCH] configure: fix gio_libs reference Bruce Rogers
@ 2020-11-03 15:00 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-11-03 15:00 UTC (permalink / raw)
To: Bruce Rogers, qemu-devel; +Cc: peter.maydell, philmd
On 03/11/20 15:51, Bruce Rogers wrote:
> The gio library detection code no longer works, due to a missing $ in
> front of the gio_libs reference. Make the string be $gio_libs.
>
> Fixes: 76346b6264a ("configure: Test that gio libs from pkg-config
> work")
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2c3c69f118..bc06aa81e5 100755
> --- a/configure
> +++ b/configure
> @@ -3499,7 +3499,7 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
> # with pkg-config --static --libs data for gio-2.0 that is missing
> # -lblkid and will give a link error.
> write_c_skeleton
> - if compile_prog "" "gio_libs" ; then
> + if compile_prog "" "$gio_libs" ; then
> gio=yes
> else
> gio=no
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-03 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-03 14:51 [PATCH] configure: fix gio_libs reference Bruce Rogers
2020-11-03 15:00 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).