From: Greg Kurz <groug@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, Dov Murik <dovmurik@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH-for-5.2 0/4] misc: Trivial format string fixes
Date: Tue, 3 Nov 2020 16:20:19 +0100 [thread overview]
Message-ID: <20201103162019.299112a8@bahia.lan> (raw)
In-Reply-To: <e2ae5627-a55d-909b-8591-f7c0400cd57c@redhat.com>
On Tue, 3 Nov 2020 15:28:11 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> On 11/3/20 3:03 PM, Dov Murik wrote:
> >
> > On 03/11/2020 15:58, Dov Murik wrote:
> >> On 03/11/2020 13:25, Philippe Mathieu-Daudé wrote:
> >>> IIUC qemu-trivial@ doesn't queue patches during freeze,
> >>>
> >>> so it might be easier if patches are queued by respective
> >>>
> >>> subsystem maintainers.
> >>>
> >>>
> >>>
> >>> Philippe Mathieu-Daudé (4):
> >>>
> >>> hw/display/cirrus_vga: Remove debugging code commented out
> >>>
> >>> hw/display/cirrus_vga: Fix hexadecimal format string specifier
> >>>
> >>> hw/ppc/spapr_tpm_proxy: Fix hexadecimal format string specifier
> >>>
> >>> migration/ram: Fix hexadecimal format string specifier
> >>>
> >>>
> >>>
> >>> hw/display/cirrus_vga.c | 20 +-------------------
> >>>
> >>> migration/ram.c | 2 +-
> >>>
> >>> hw/ppc/trace-events | 2 +-
> >>>
> >>> 3 files changed, 3 insertions(+), 21 deletions(-)
> >>>
> >>>
> >>>
> >>
> >>
> >> There's at least one more easy fix:
> >>
> >> hw/misc/trace-events:106:mos6522_get_next_irq_time(uint16_t latch,
> >> int64_t d, int64_t delta) "latch=%d counter=0x%"PRId64 "
> >> delta_next=0x%"PRId64
>
> Indeed.
>
> >>
> >> but I have no idea how to test this.
> >>
> >> -Dov
> >>
> >
> > ... and one more in hw/usb/u2f-passthru.c:348 :
> >
> > error_report("%s: Bad written size (req 0x%zu, val 0x%zd)",
> > TYPE_U2F_PASSTHRU, sizeof(host_packet), written);
>
> 'written' is signed, so this format looks correct...
>
Irrespective of the sign, u and d shouldn't be used behind 0x
> >
> > Again, I have no idea how to test/trigger these areas in the code.
> >
> > -Dov
> >
>
>
next prev parent reply other threads:[~2020-11-03 15:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 11:25 [PATCH-for-5.2 0/4] misc: Trivial format string fixes Philippe Mathieu-Daudé
2020-11-03 11:25 ` [PATCH-for-5.2 1/4] hw/display/cirrus_vga: Remove debugging code commented out Philippe Mathieu-Daudé
2020-11-03 12:42 ` Dr. David Alan Gilbert
2020-11-03 11:25 ` [PATCH-for-5.2 2/4] hw/display/cirrus_vga: Fix hexadecimal format string specifier Philippe Mathieu-Daudé
2020-11-03 12:45 ` Dr. David Alan Gilbert
2020-11-09 14:29 ` Philippe Mathieu-Daudé
2020-11-03 11:25 ` [PATCH-for-5.2 3/4] hw/ppc/spapr_tpm_proxy: " Philippe Mathieu-Daudé
2020-11-03 11:39 ` David Gibson
2020-11-09 14:28 ` Philippe Mathieu-Daudé
2020-11-23 6:15 ` David Gibson
2020-11-03 11:40 ` Greg Kurz
2020-11-03 11:25 ` [PATCH-for-5.2 4/4] migration/ram: " Philippe Mathieu-Daudé
2020-11-03 12:46 ` Dr. David Alan Gilbert
2020-11-09 14:30 ` Philippe Mathieu-Daudé
2020-11-09 15:01 ` Dr. David Alan Gilbert
2020-11-12 14:03 ` Dr. David Alan Gilbert
2020-11-03 13:58 ` [PATCH-for-5.2 0/4] misc: Trivial format string fixes Dov Murik
2020-11-03 14:03 ` Dov Murik
2020-11-03 14:28 ` Philippe Mathieu-Daudé
2020-11-03 15:20 ` Greg Kurz [this message]
2020-11-03 15:44 ` Philippe Mathieu-Daudé
2020-11-03 15:26 ` Dov Murik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103162019.299112a8@bahia.lan \
--to=groug@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=dovmurik@linux.vnet.ibm.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).