From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2] trace: remove argument from trace_init_file
Date: Tue, 3 Nov 2020 16:25:38 +0000 [thread overview]
Message-ID: <20201103162538.GD253848@stefanha-x1.localdomain> (raw)
In-Reply-To: <20201102115841.4017692-1-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On Mon, Nov 02, 2020 at 06:58:41AM -0500, Paolo Bonzini wrote:
> It is not needed, all the callers are just saving what was
> retrieved from -trace and trace_init_file can retrieve it
> on its own.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> bsd-user/main.c | 6 ++----
> linux-user/main.c | 6 ++----
> qemu-img.c | 6 ++----
> qemu-io.c | 6 ++----
> qemu-nbd.c | 6 ++----
> scsi/qemu-pr-helper.c | 6 ++----
> softmmu/vl.c | 6 ++----
> storage-daemon/qemu-storage-daemon.c | 9 +++------
> trace/control.c | 10 ++++------
> trace/control.h | 12 +++---------
> 10 files changed, 24 insertions(+), 49 deletions(-)
Thanks, applied to my tracing tree:
https://gitlab.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-11-03 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 11:58 [PATCH v2] trace: remove argument from trace_init_file Paolo Bonzini
2020-11-03 16:25 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103162538.GD253848@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).