From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH-for-5.2 1/3] s390x: fix build for --without-default-devices
Date: Tue, 3 Nov 2020 17:46:02 +0100 [thread overview]
Message-ID: <20201103164604.2692357-2-philmd@redhat.com> (raw)
In-Reply-To: <20201103164604.2692357-1-philmd@redhat.com>
From: Cornelia Huck <cohuck@redhat.com>
s390-pci-vfio.c calls into the vfio code, so we need it to be
built conditionally on vfio (which implies CONFIG_LINUX).
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Fixes: cd7498d07fbb ("s390x/pci: Add routine to get the vfio dma available count")
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20201103123237.718242-1-cohuck@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/s390x/s390-pci-vfio.h | 3 ++-
hw/s390x/meson.build | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/hw/s390x/s390-pci-vfio.h b/include/hw/s390x/s390-pci-vfio.h
index c7984905b3b..ff708aef500 100644
--- a/include/hw/s390x/s390-pci-vfio.h
+++ b/include/hw/s390x/s390-pci-vfio.h
@@ -13,8 +13,9 @@
#define HW_S390_PCI_VFIO_H
#include "hw/s390x/s390-pci-bus.h"
+#include CONFIG_DEVICES
-#ifdef CONFIG_LINUX
+#ifdef CONFIG_VFIO
bool s390_pci_update_dma_avail(int fd, unsigned int *avail);
S390PCIDMACount *s390_pci_start_dma_count(S390pciState *s,
S390PCIBusDevice *pbdev);
diff --git a/hw/s390x/meson.build b/hw/s390x/meson.build
index f4663a83551..2a7818d94b9 100644
--- a/hw/s390x/meson.build
+++ b/hw/s390x/meson.build
@@ -27,7 +27,7 @@
))
s390x_ss.add(when: 'CONFIG_S390_CCW_VIRTIO', if_true: files('s390-virtio-ccw.c'))
s390x_ss.add(when: 'CONFIG_TERMINAL3270', if_true: files('3270-ccw.c'))
-s390x_ss.add(when: 'CONFIG_LINUX', if_true: files('s390-pci-vfio.c'))
+s390x_ss.add(when: 'CONFIG_VFIO', if_true: files('s390-pci-vfio.c'))
virtio_ss = ss.source_set()
virtio_ss.add(files('virtio-ccw.c'))
--
2.26.2
next prev parent reply other threads:[~2020-11-03 16:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 16:46 [PATCH-for-5.2 0/3] ci: Move --without-default-devices job from Travis to GitLab Philippe Mathieu-Daudé
2020-11-03 16:46 ` Philippe Mathieu-Daudé [this message]
2020-11-03 16:46 ` [PATCH-for-5.2 2/3] gitlab-ci: Add a job to cover the --without-default-devices config Philippe Mathieu-Daudé
2020-11-03 16:52 ` Daniel P. Berrangé
2020-11-03 17:01 ` Philippe Mathieu-Daudé
2020-11-03 17:02 ` Daniel P. Berrangé
2020-11-03 17:04 ` Philippe Mathieu-Daudé
2020-11-04 2:27 ` Stefano Stabellini
2020-11-04 6:17 ` Thomas Huth
2020-11-05 4:26 ` Stefano Stabellini
2020-11-05 8:19 ` Philippe Mathieu-Daudé
2020-11-04 8:12 ` Paolo Bonzini
2020-11-05 2:48 ` Stefano Stabellini
2020-11-05 11:00 ` Paolo Bonzini
2020-11-03 20:57 ` Paolo Bonzini
2020-11-03 21:07 ` Philippe Mathieu-Daudé
2020-11-03 21:12 ` Paolo Bonzini
2020-11-04 8:45 ` Philippe Mathieu-Daudé
2020-11-03 17:02 ` Philippe Mathieu-Daudé
2020-11-03 18:43 ` Thomas Huth
2020-11-03 20:41 ` Philippe Mathieu-Daudé
2020-11-04 6:21 ` Thomas Huth
2020-11-04 8:32 ` Philippe Mathieu-Daudé
2020-11-04 9:15 ` Thomas Huth
2020-11-03 16:46 ` [PATCH-for-5.2 3/3] travis-ci: Remove the --without-default-devices job Philippe Mathieu-Daudé
2020-11-03 18:51 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103164604.2692357-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=fam@euphon.net \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).