qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Bharat Bhushan <bbhushan2@marvell.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Eric Auger <eric.auger@redhat.com>
Subject: [PULL v2 18/38] virtio-iommu: Add notify_flag_changed() memory region callback
Date: Tue, 3 Nov 2020 23:51:30 -0500	[thread overview]
Message-ID: <20201104044937.226370-19-mst@redhat.com> (raw)
In-Reply-To: <20201104044937.226370-1-mst@redhat.com>

From: Bharat Bhushan <bbhushan2@marvell.com>

Add notify_flag_changed() to notice when memory listeners are added and
removed.

Acked-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Bharat Bhushan <bbhushan2@marvell.com>
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Message-Id: <20201030180510.747225-7-jean-philippe@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/virtio/virtio-iommu.c | 14 ++++++++++++++
 hw/virtio/trace-events   |  2 ++
 2 files changed, 16 insertions(+)

diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index 985257c88f..78e07aa40a 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -886,6 +886,19 @@ unlock:
     qemu_mutex_unlock(&s->mutex);
 }
 
+static int virtio_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu_mr,
+                                            IOMMUNotifierFlag old,
+                                            IOMMUNotifierFlag new,
+                                            Error **errp)
+{
+    if (old == IOMMU_NOTIFIER_NONE) {
+        trace_virtio_iommu_notify_flag_add(iommu_mr->parent_obj.name);
+    } else if (new == IOMMU_NOTIFIER_NONE) {
+        trace_virtio_iommu_notify_flag_del(iommu_mr->parent_obj.name);
+    }
+    return 0;
+}
+
 static void virtio_iommu_device_realize(DeviceState *dev, Error **errp)
 {
     VirtIODevice *vdev = VIRTIO_DEVICE(dev);
@@ -1116,6 +1129,7 @@ static void virtio_iommu_memory_region_class_init(ObjectClass *klass,
 
     imrc->translate = virtio_iommu_translate;
     imrc->replay = virtio_iommu_replay;
+    imrc->notify_flag_changed = virtio_iommu_notify_flag_changed;
 }
 
 static const TypeInfo virtio_iommu_info = {
diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
index ea3c3b25ad..982d0002a6 100644
--- a/hw/virtio/trace-events
+++ b/hw/virtio/trace-events
@@ -109,6 +109,8 @@ virtio_iommu_fill_resv_property(uint32_t devid, uint8_t subtype, uint64_t start,
 virtio_iommu_notify_map(const char *name, uint64_t virt_start, uint64_t virt_end, uint64_t phys_start, uint32_t flags) "mr=%s virt_start=0x%"PRIx64" virt_end=0x%"PRIx64" phys_start=0x%"PRIx64" flags=%d"
 virtio_iommu_notify_unmap(const char *name, uint64_t virt_start, uint64_t virt_end) "mr=%s virt_start=0x%"PRIx64" virt_end=0x%"PRIx64
 virtio_iommu_remap(const char *name, uint64_t virt_start, uint64_t virt_end, uint64_t phys_start) "mr=%s virt_start=0x%"PRIx64" virt_end=0x%"PRIx64" phys_start=0x%"PRIx64
+virtio_iommu_notify_flag_add(const char *name) "add notifier to mr %s"
+virtio_iommu_notify_flag_del(const char *name) "del notifier from mr %s"
 
 # virtio-mem.c
 virtio_mem_send_response(uint16_t type) "type=%" PRIu16
-- 
MST



  parent reply	other threads:[~2020-11-04  4:59 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04  4:50 [PULL v2 00/38] pc,pci,vhost,virtio: fixes Michael S. Tsirkin
2020-11-04  4:50 ` [PULL v2 01/38] pc: comment style fixup Michael S. Tsirkin
2020-11-04  4:50 ` [PULL v2 02/38] virtio-mem: Make sure "addr" is always multiples of the block size Michael S. Tsirkin
2020-11-04  4:50 ` [PULL v2 03/38] virtio-mem: Make sure "usable_region_size" " Michael S. Tsirkin
2020-11-04  4:50 ` [PULL v2 04/38] virtio-mem: Probe THP size to determine default " Michael S. Tsirkin
2020-11-04  4:50 ` [PULL v2 05/38] memory-device: Support big alignment requirements Michael S. Tsirkin
2020-11-04  4:50 ` [PULL v2 06/38] memory-device: Add get_min_alignment() callback Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 07/38] virito-mem: Implement get_min_alignment() Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 08/38] hw/acpi : Don't use '#' flag of printf format Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 09/38] hw/acpi : add space before the open parenthesis '(' Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 10/38] hw/acpi : add spaces around operator Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 11/38] hw/virtio/vhost-backend: Fix Coverity CID 1432871 Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 12/38] hw/smbios: Fix leaked fd in save_opt_one() error path Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 13/38] virtio-iommu: Fix virtio_iommu_mr() Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 14/38] virtio-iommu: Store memory region in endpoint struct Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 15/38] virtio-iommu: Add memory notifiers for map/unmap Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 16/38] virtio-iommu: Call memory notifiers in attach/detach Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 17/38] virtio-iommu: Add replay() memory region callback Michael S. Tsirkin
2020-11-04  4:51 ` Michael S. Tsirkin [this message]
2020-11-04  4:51 ` [PULL v2 19/38] memory: Add interface to set iommu page size mask Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 20/38] vfio: Set IOMMU page size as per host supported page size Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 21/38] virtio-iommu: Set supported page size mask Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 22/38] vfio: Don't issue full 2^64 unmap Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 23/38] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 24/38] net: Add vhost-vdpa in show_netdevs() Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 25/38] Revert "vhost-blk: set features before setting inflight feature" Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 26/38] vhost-blk: set features before setting inflight feature Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 27/38] libvhost-user: follow QEMU comment style Michael S. Tsirkin
2020-11-04  4:51 ` [PULL v2 28/38] configure: introduce --enable-vhost-user-blk-server Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 29/38] block/export: make vhost-user-blk config space little-endian Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 30/38] block/export: fix vhost-user-blk get_config() information leak Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 31/38] contrib/vhost-user-blk: fix " Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 32/38] test: new qTest case to test the vhost-user-blk-server Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 33/38] tests/qtest: add multi-queue test case to vhost-user-blk-test Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 34/38] libqtest: add qtest_socket_server() Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 35/38] vhost-user-blk-test: rename destroy_drive() to destroy_file() Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 36/38] vhost-user-blk-test: close fork child file descriptors Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 37/38] vhost-user-blk-test: drop unused return value Michael S. Tsirkin
2020-11-04  4:52 ` [PULL v2 38/38] vhost-user-blk-test: fix races by using fd passing Michael S. Tsirkin
2020-11-04 10:28 ` [PULL v2 00/38] pc,pci,vhost,virtio: fixes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104044937.226370-19-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=bbhushan2@marvell.com \
    --cc=eric.auger@redhat.com \
    --cc=jean-philippe@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).