From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-block@nongnu.org, Coiby Xu <Coiby.Xu@gmail.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PULL v2 29/38] block/export: make vhost-user-blk config space little-endian
Date: Tue, 3 Nov 2020 23:52:00 -0500 [thread overview]
Message-ID: <20201104044937.226370-30-mst@redhat.com> (raw)
In-Reply-To: <20201104044937.226370-1-mst@redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
VIRTIO 1.0 devices have little-endian configuration space. The
vhost-user-blk-server.c code already uses little-endian for virtqueue
processing but not for the configuration space fields. Fix this so the
vhost-user-blk export works on big-endian hosts.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20201027173528.213464-4-stefanha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
block/export/vhost-user-blk-server.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user-blk-server.c
index 41f4933d6e..33cc0818b8 100644
--- a/block/export/vhost-user-blk-server.c
+++ b/block/export/vhost-user-blk-server.c
@@ -264,7 +264,6 @@ static uint64_t vu_blk_get_protocol_features(VuDev *dev)
static int
vu_blk_get_config(VuDev *vu_dev, uint8_t *config, uint32_t len)
{
- /* TODO blkcfg must be little-endian for VIRTIO 1.0 */
VuServer *server = container_of(vu_dev, VuServer, vu_dev);
VuBlkExport *vexp = container_of(server, VuBlkExport, vu_server);
memcpy(config, &vexp->blkcfg, len);
@@ -343,18 +342,18 @@ vu_blk_initialize_config(BlockDriverState *bs,
uint32_t blk_size,
uint16_t num_queues)
{
- config->capacity = bdrv_getlength(bs) >> BDRV_SECTOR_BITS;
- config->blk_size = blk_size;
- config->size_max = 0;
- config->seg_max = 128 - 2;
- config->min_io_size = 1;
- config->opt_io_size = 1;
- config->num_queues = num_queues;
- config->max_discard_sectors = 32768;
- config->max_discard_seg = 1;
- config->discard_sector_alignment = config->blk_size >> 9;
- config->max_write_zeroes_sectors = 32768;
- config->max_write_zeroes_seg = 1;
+ config->capacity = cpu_to_le64(bdrv_getlength(bs) >> BDRV_SECTOR_BITS);
+ config->blk_size = cpu_to_le32(blk_size);
+ config->size_max = cpu_to_le32(0);
+ config->seg_max = cpu_to_le32(128 - 2);
+ config->min_io_size = cpu_to_le16(1);
+ config->opt_io_size = cpu_to_le32(1);
+ config->num_queues = cpu_to_le16(num_queues);
+ config->max_discard_sectors = cpu_to_le32(32768);
+ config->max_discard_seg = cpu_to_le32(1);
+ config->discard_sector_alignment = cpu_to_le32(config->blk_size >> 9);
+ config->max_write_zeroes_sectors = cpu_to_le32(32768);
+ config->max_write_zeroes_seg = cpu_to_le32(1);
}
static void vu_blk_exp_request_shutdown(BlockExport *exp)
--
MST
next prev parent reply other threads:[~2020-11-04 5:02 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 4:50 [PULL v2 00/38] pc,pci,vhost,virtio: fixes Michael S. Tsirkin
2020-11-04 4:50 ` [PULL v2 01/38] pc: comment style fixup Michael S. Tsirkin
2020-11-04 4:50 ` [PULL v2 02/38] virtio-mem: Make sure "addr" is always multiples of the block size Michael S. Tsirkin
2020-11-04 4:50 ` [PULL v2 03/38] virtio-mem: Make sure "usable_region_size" " Michael S. Tsirkin
2020-11-04 4:50 ` [PULL v2 04/38] virtio-mem: Probe THP size to determine default " Michael S. Tsirkin
2020-11-04 4:50 ` [PULL v2 05/38] memory-device: Support big alignment requirements Michael S. Tsirkin
2020-11-04 4:50 ` [PULL v2 06/38] memory-device: Add get_min_alignment() callback Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 07/38] virito-mem: Implement get_min_alignment() Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 08/38] hw/acpi : Don't use '#' flag of printf format Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 09/38] hw/acpi : add space before the open parenthesis '(' Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 10/38] hw/acpi : add spaces around operator Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 11/38] hw/virtio/vhost-backend: Fix Coverity CID 1432871 Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 12/38] hw/smbios: Fix leaked fd in save_opt_one() error path Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 13/38] virtio-iommu: Fix virtio_iommu_mr() Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 14/38] virtio-iommu: Store memory region in endpoint struct Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 15/38] virtio-iommu: Add memory notifiers for map/unmap Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 16/38] virtio-iommu: Call memory notifiers in attach/detach Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 17/38] virtio-iommu: Add replay() memory region callback Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 18/38] virtio-iommu: Add notify_flag_changed() " Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 19/38] memory: Add interface to set iommu page size mask Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 20/38] vfio: Set IOMMU page size as per host supported page size Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 21/38] virtio-iommu: Set supported page size mask Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 22/38] vfio: Don't issue full 2^64 unmap Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 23/38] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 24/38] net: Add vhost-vdpa in show_netdevs() Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 25/38] Revert "vhost-blk: set features before setting inflight feature" Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 26/38] vhost-blk: set features before setting inflight feature Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 27/38] libvhost-user: follow QEMU comment style Michael S. Tsirkin
2020-11-04 4:51 ` [PULL v2 28/38] configure: introduce --enable-vhost-user-blk-server Michael S. Tsirkin
2020-11-04 4:52 ` Michael S. Tsirkin [this message]
2020-11-04 4:52 ` [PULL v2 30/38] block/export: fix vhost-user-blk get_config() information leak Michael S. Tsirkin
2020-11-04 4:52 ` [PULL v2 31/38] contrib/vhost-user-blk: fix " Michael S. Tsirkin
2020-11-04 4:52 ` [PULL v2 32/38] test: new qTest case to test the vhost-user-blk-server Michael S. Tsirkin
2020-11-04 4:52 ` [PULL v2 33/38] tests/qtest: add multi-queue test case to vhost-user-blk-test Michael S. Tsirkin
2020-11-04 4:52 ` [PULL v2 34/38] libqtest: add qtest_socket_server() Michael S. Tsirkin
2020-11-04 4:52 ` [PULL v2 35/38] vhost-user-blk-test: rename destroy_drive() to destroy_file() Michael S. Tsirkin
2020-11-04 4:52 ` [PULL v2 36/38] vhost-user-blk-test: close fork child file descriptors Michael S. Tsirkin
2020-11-04 4:52 ` [PULL v2 37/38] vhost-user-blk-test: drop unused return value Michael S. Tsirkin
2020-11-04 4:52 ` [PULL v2 38/38] vhost-user-blk-test: fix races by using fd passing Michael S. Tsirkin
2020-11-04 10:28 ` [PULL v2 00/38] pc,pci,vhost,virtio: fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104044937.226370-30-mst@redhat.com \
--to=mst@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).