From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB94DC2D0A3 for ; Wed, 4 Nov 2020 12:27:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB1D2208C7 for ; Wed, 4 Nov 2020 12:27:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Csgb8ENI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB1D2208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaHsZ-0003PE-Mk for qemu-devel@archiver.kernel.org; Wed, 04 Nov 2020 07:27:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaHoO-0008CE-LB for qemu-devel@nongnu.org; Wed, 04 Nov 2020 07:22:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kaHo9-0000Wa-By for qemu-devel@nongnu.org; Wed, 04 Nov 2020 07:22:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604492552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3AZmQ0g1rLJhMsG0GXJFrA7THwFvrVGwbTpKAJR3vBc=; b=Csgb8ENItBKmNqLuGW/c6fWxTXJFHmW8whcpEdZhZzIAeNHWZ2QaSX5ev6OIeko8efJ6Cs n4SlSvWhWZqz+wSxaScb5QMyqnywaNl2R/bm6wrDsyEWAXvN153cVOPZcWbzveOVo1yMnN 5gxARUM+Q7IWEoQeZDAzoVBNlft3Yoo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-LMKXIZisO4GCY65kq5UK_Q-1; Wed, 04 Nov 2020 07:22:28 -0500 X-MC-Unique: LMKXIZisO4GCY65kq5UK_Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5665E11BD343; Wed, 4 Nov 2020 12:22:27 +0000 (UTC) Received: from gondolin (ovpn-114-18.ams2.redhat.com [10.36.114.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id E282B60C84; Wed, 4 Nov 2020 12:22:25 +0000 (UTC) Date: Wed, 4 Nov 2020 13:22:23 +0100 From: Cornelia Huck To: Christian Borntraeger Subject: Re: [PATCH] s390-bios: Skip writing iplb location to low core for ccw ipl Message-ID: <20201104132223.1ff51e5c.cohuck@redhat.com> In-Reply-To: <20201030122823.347140-1-borntraeger@de.ibm.com> References: <20201030122823.347140-1-borntraeger@de.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x , "Jason J. Herne" , Thomas Huth , qemu-devel , Janosch Frank Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 30 Oct 2020 13:28:23 +0100 Christian Borntraeger wrote: > From: "Jason J. Herne" > > The architecture states that the iplb location is only written to low > core for list directed ipl and not for traditional ccw ipl. If we don't > skip this then operating systems that load by reading into low core > memory may fail to start. > > We should also not write the iplb pointer for network boot as it might > overwrite content that we got via network. > > Signed-off-by: Jason J. Herne > Fixes: 9bfc04f9ef68 ("pc-bios: s390x: Save iplb location in lowcore") > Signed-off-by: Christian Borntraeger > --- > pc-bios/s390-ccw/main.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Thanks, queued (together with a rebuild) to s390-fixes.