From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 867E2C00A89 for ; Thu, 5 Nov 2020 12:25:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A43D620729 for ; Thu, 5 Nov 2020 12:25:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A43D620729 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaeKA-0008OO-5K for qemu-devel@archiver.kernel.org; Thu, 05 Nov 2020 07:25:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaeJ1-0007vI-7L; Thu, 05 Nov 2020 07:23:55 -0500 Received: from smtpout1.mo529.mail-out.ovh.net ([178.32.125.2]:52067) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaeIy-00030S-VY; Thu, 05 Nov 2020 07:23:54 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.109.156.217]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 632D06A9D11B; Thu, 5 Nov 2020 13:23:48 +0100 (CET) Received: from kaod.org (37.59.142.98) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 5 Nov 2020 13:23:47 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-98R002f4d6e030-ceec-415c-9026-00fee129f7cd, 5D04B6D4EAACA18D9EDEF493C42F41A1D3896549) smtp.auth=groug@kaod.org Date: Thu, 5 Nov 2020 13:23:46 +0100 From: Greg Kurz To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH-for-5.2 v3 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen Message-ID: <20201105132346.5e0adf94@bahia.lan> In-Reply-To: <17370310-d69c-91ff-763d-52a1355ad605@redhat.com> References: <20201104115706.3101190-1-philmd@redhat.com> <20201104115706.3101190-3-philmd@redhat.com> <8965407.pN9RvXrJQ9@silver> <20201104185439.41e9ddb3@bahia.lan> <17370310-d69c-91ff-763d-52a1355ad605@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [37.59.142.98] X-ClientProxiedBy: DAG6EX1.mxp5.local (172.16.2.51) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: b0c3b55b-f88a-4045-9165-58d4c97a7207 X-Ovh-Tracer-Id: 17209380080369375504 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedruddtjedggedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfhisehtqhertdertdejnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeevlefhtddufffhieevhefhleegleelgfetffetkedugeehjeffgfehhfefueduffenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddrleeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehrthhhsehtfihiuggulhgvrdhnvght Received-SPF: pass client-ip=178.32.125.2; envelope-from=groug@kaod.org; helo=smtpout1.mo529.mail-out.ovh.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 07:23:50 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Thomas Huth , Stefano Stabellini , "Daniel P . Berrange" , Matthew Rosato , David Hildenbrand , Cornelia Huck , Christian Schoenebeck , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Alex =?UTF-8?B?QmVubsOpZQ==?= , Paul Durrant , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 5 Nov 2020 13:15:59 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > On 11/4/20 6:54 PM, Greg Kurz wrote: > > On Wed, 04 Nov 2020 13:18:09 +0100 > > Christian Schoenebeck wrote: > >=20 > >> On Mittwoch, 4. November 2020 12:57:04 CET Philippe Mathieu-Daud=C3=A9= wrote: > >>> Commit b2c00bce54c ("meson: convert hw/9pfs, cleanup") introduced > >>> CONFIG_9PFS (probably a wrong conflict resolution). This config is > >>> not used anywhere. Backends depend on CONFIG_FSDEV_9P which itself > >>> depends on CONFIG_VIRTFS. > >>> > >>> Remove the invalid CONFIG_9PFS and use CONFIG_FSDEV_9P instead, to > >>> fix the './configure --without-default-devices --enable-xen' build: > >>> > >>> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in funct= ion > >>> `xen_be_register_common': hw/xen/xen-legacy-backend.c:754: undefined > >>> reference to `xen_9pfs_ops' /usr/bin/ld: > >>> libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined refere= nce to > >>> `local_ops' /usr/bin/ld: > >>> libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined refer= ence > >>> to `synth_ops' /usr/bin/ld: > >>> libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined refer= ence > >>> to `proxy_ops' collect2: error: ld returned 1 exit status > >>> > >>> Fixes: b2c00bce54c ("meson: convert hw/9pfs, cleanup") > >>> Suggested-by: Paolo Bonzini > >>> Acked-by: Greg Kurz > >>> Tested-by: Greg Kurz > >>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >> > >> Acked-by: Christian Schoenebeck > >> > >=20 > > Phil, > >=20 > > Same questioning as Connie. Do you intend to get this merged or should > > Christian or I take care of that ? >=20 > Same answer too =3D) If you are preparing a pull request, please go ahead! >=20 Heh I've just seen your answer. Christian, Maybe you can add this patch in your next PR ? > Thanks, >=20 > Phil. >=20