From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Zheng Chuan <zhengchuan@huawei.com>
Cc: yubihong@huawei.com, zhang.zhanghailiang@huawei.com,
quintela@redhat.com, qemu-devel@nongnu.org,
xiexiangyou@huawei.com, alex.chen@huawei.com,
wanghao232@huawei.com
Subject: Re: [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c
Date: Fri, 6 Nov 2020 16:53:58 +0000 [thread overview]
Message-ID: <20201106165358.GN3576@work-vm> (raw)
In-Reply-To: <a0f1a800-e9dc-d5df-6082-ffdcd5b8dfc5@huawei.com>
* Zheng Chuan (zhengchuan@huawei.com) wrote:
> Kindly ping for not forgetting this trivial fix:)
Yes but it's too late for the merge window, so it'll happen on the next
one, no rush!
Dave
> On 2020/10/30 22:09, Mark Kanda wrote:
> > On 10/29/2020 10:58 PM, Chuan Zheng wrote:
> >> Remove redundant blank line which is left by Commit 662770af7c6e8c,
> >> also take this opportunity to remove redundant includes in dirtyrate.c.
> >>
> >> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
> >
> > Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> >
> >> ---
> >> Â migration/dirtyrate.c | 5 -----
> >> Â 1 file changed, 5 deletions(-)
> >>
> >> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> >> index 8f728d2..ccb9814 100644
> >> --- a/migration/dirtyrate.c
> >> +++ b/migration/dirtyrate.c
> >> @@ -11,17 +11,12 @@
> >> Â Â */
> >> Â Â #include "qemu/osdep.h"
> >> -
> >> Â #include <zlib.h>
> >> Â #include "qapi/error.h"
> >> Â #include "cpu.h"
> >> -#include "qemu/config-file.h"
> >> -#include "exec/memory.h"
> >> Â #include "exec/ramblock.h"
> >> -#include "exec/target_page.h"
> >> Â #include "qemu/rcu_queue.h"
> >> Â #include "qapi/qapi-commands-migration.h"
> >> -#include "migration.h"
> >> Â #include "ram.h"
> >> Â #include "trace.h"
> >> Â #include "dirtyrate.h"
> >>
>
> --
> Regards.
> Chuan
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-11-06 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 3:58 [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c Chuan Zheng
2020-10-30 14:09 ` Mark Kanda
2020-11-06 6:24 ` Zheng Chuan
2020-11-06 16:53 ` Dr. David Alan Gilbert [this message]
2020-11-12 14:55 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106165358.GN3576@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.chen@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wanghao232@huawei.com \
--cc=xiexiangyou@huawei.com \
--cc=yubihong@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).