qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH-for-5.2 v4 01/17] configure: Check vhost-user is available to build vhost-user-blk-server
Date: Sun,  8 Nov 2020 21:45:19 +0100	[thread overview]
Message-ID: <20201108204535.2319870-2-philmd@redhat.com> (raw)
In-Reply-To: <20201108204535.2319870-1-philmd@redhat.com>

Check vhost-user is available to build vhost-user-blk-server to fix:

 $ ../configure \
      --disable-vhost-user --enable-vhost-user-blk-server && \
   make qemu-nbd
 ...
 [505/505] Linking target qemu-nbd
 FAILED: qemu-nbd
 cc  -o qemu-nbd qemu-nbd.p/qemu-nbd.c.o -Wl,--as-needed -Wl,--no-undefined -pie -Wl,--whole-archive libblockdev.fa libblock.fa libcrypto.fa libauthz.fa libqom.fa libio.fa -Wl,--no-whole-archive -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -m64 -fstack-protector-strong -Wl,--start-group libqemuutil.a libblockdev.fa libblock.fa libcrypto.fa libauthz.fa libqom.fa libio.fa @block.syms -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -pthread -lgnutls -lutil -lm -lgthread-2.0 -lglib-2.0 -lbz2 -lgthread-2.0 -lglib-2.0 -lssh -lrbd -lrados -lcurl -lxml2 -lzstd -lacl -lgfapi -lglusterfs -lgfrpc -lgfxdr -luuid -laio /usr/lib64/libz.so -L/usr/lib64/iscsi -liscsi -lnettle -lgnutls -lpam -Wl,--end-group
 /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in function `vu_blk_process_vq':
 block/export/vhost-user-blk-server.c:203: undefined reference to `vu_get_queue'
 /usr/bin/ld: block/export/vhost-user-blk-server.c:208: undefined reference to `vu_queue_pop'
 /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in function `vu_blk_queue_set_started':
 block/export/vhost-user-blk-server.c:228: undefined reference to `vu_get_queue'
 /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in function `vu_blk_req_complete':
 block/export/vhost-user-blk-server.c:55: undefined reference to `vu_queue_push'
 /usr/bin/ld: block/export/vhost-user-blk-server.c:56: undefined reference to `vu_queue_notify'
 /usr/bin/ld: libblockdev.fa(block_export_vhost-user-blk-server.c.o): in function `vu_blk_queue_set_started':
 block/export/vhost-user-blk-server.c:229: undefined reference to `vu_set_queue_handler'
 /usr/bin/ld: libqemuutil.a(util_vhost-user-server.c.o): in function `vu_client_trip':
 util/vhost-user-server.c:176: undefined reference to `vu_dispatch'
 /usr/bin/ld: util/vhost-user-server.c:180: undefined reference to `vu_deinit'
 /usr/bin/ld: libqemuutil.a(util_vhost-user-server.c.o): in function `vu_accept':
 util/vhost-user-server.c:291: undefined reference to `vu_init'
 collect2: error: ld returned 1 exit status
 ninja: build stopped: subcommand failed.
 make: *** [Makefile:171: run-ninja] Error 1

Fixes: bc15e44cb21 ("configure: introduce --enable-vhost-user-blk-server")
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 configure | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure b/configure
index 805f7791503..5079ebb416a 100755
--- a/configure
+++ b/configure
@@ -2390,6 +2390,9 @@ fi
 
 # libvhost-user is Linux-only
 test "$vhost_user_blk_server" = "" && vhost_user_blk_server=$linux
+if test "$vhost_user_blk_server" = "yes" && test "$vhost_user" = "no"; then
+  error_exit "--enable-vhost-user-blk-server requires --enable-vhost-user"
+fi
 if test "$vhost_user_blk_server" = "yes" && test "$linux" = "no"; then
   error_exit "--enable-vhost-user-blk-server is only available on Linux"
 fi
-- 
2.26.2



  reply	other threads:[~2020-11-08 20:46 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08 20:45 [PATCH-for-5.2 v4 00/17] ci: Move various jobs from Travis to GitLab CI Philippe Mathieu-Daudé
2020-11-08 20:45 ` Philippe Mathieu-Daudé [this message]
2020-11-09  8:34   ` [PATCH-for-5.2 v4 01/17] configure: Check vhost-user is available to build vhost-user-blk-server Thomas Huth
2020-11-08 20:45 ` [PATCH-for-5.2 v4 02/17] meson: always include contrib/libvhost-user Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-5.2 v4 03/17] hw/i386/acpi-build: Fix maybe-uninitialized error when ACPI hotplug off Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 04/17] MAINTAINERS: Add gitlab-pipeline-status script to GitLab CI section Philippe Mathieu-Daudé
2020-11-09 10:06   ` Thomas Huth
2020-11-09 19:29   ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 05/17] gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled Philippe Mathieu-Daudé
2020-11-09 20:57   ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options Philippe Mathieu-Daudé
2020-11-09 10:16   ` Thomas Huth
2020-11-08 20:45 ` [PATCH-for-6.0 v4 07/17] gitlab-ci: Move job testing --without-default-devices across to gitlab Philippe Mathieu-Daudé
2020-11-09 10:20   ` Thomas Huth
2020-11-09 11:04     ` Philippe Mathieu-Daudé
2020-11-09 11:18       ` Thomas Huth
2020-11-09 13:02         ` Philippe Mathieu-Daudé
2020-11-10 13:44   ` Wainer dos Santos Moschetta
2020-11-10 14:01     ` Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 08/17] gitlab-ci: Move linux-user debug-tcg test " Philippe Mathieu-Daudé
2020-11-10 14:23   ` Wainer dos Santos Moschetta
2020-11-10 19:34   ` Alex Bennée
2020-11-08 20:45 ` [PATCH-for-6.0 v4 09/17] gitlab-ci: Move gprof/gcov " Philippe Mathieu-Daudé
2020-11-10 15:03   ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 10/17] gitlab-ci: Move user-static " Philippe Mathieu-Daudé
2020-11-10 15:06   ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 11/17] gitlab-ci: Move tools-only and softfloat tests " Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 12/17] gitlab-ci: Move coroutine " Philippe Mathieu-Daudé
2020-11-09  9:42   ` Stefan Hajnoczi
2020-11-10 17:15   ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 13/17] tests/docker: Install lttng-ust-devel package in Fedora image Philippe Mathieu-Daudé
2020-11-09  9:42   ` Stefan Hajnoczi
2020-11-10 17:29   ` Wainer dos Santos Moschetta
2020-11-08 20:45 ` [PATCH-for-6.0 v4 14/17] gitlab-ci: Move trace backend tests across to gitlab Philippe Mathieu-Daudé
2020-11-09  9:48   ` Stefan Hajnoczi
2020-11-10 18:12   ` Wainer dos Santos Moschetta
2020-11-11  8:42     ` Philippe Mathieu-Daudé
2020-11-11  8:45       ` Philippe Mathieu-Daudé
2020-11-11  8:50       ` Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 15/17] gitlab-ci: Add test for Xen (on CentOS 7) Philippe Mathieu-Daudé
2020-11-26 17:38   ` Anthony PERARD via
2020-11-26 17:45     ` Eduardo Habkost
2020-11-27 14:24       ` Anthony PERARD via
2020-11-30 21:28         ` Stefano Stabellini
2020-11-08 20:45 ` [PATCH-for-6.0 v4 16/17] gitlab-ci: Make some ARM 32-bit jobs optional Philippe Mathieu-Daudé
2020-11-08 22:00   ` Philippe Mathieu-Daudé
2020-11-08 20:45 ` [PATCH-for-6.0 v4 17/17] gitlab-ci: Make MIPS user-mode 32-bit little-endian job optional Philippe Mathieu-Daudé
2020-11-10 15:55 ` [PATCH-for-5.2 v4 00/17] ci: Move various jobs from Travis to GitLab CI Alex Bennée
2020-11-10 16:07   ` Philippe Mathieu-Daudé
2020-12-09 11:06 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201108204535.2319870-2-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=fam@euphon.net \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).