From: Cornelia Huck <cohuck@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Matthew Rosato <mjrosato@linux.ibm.com>,
Paul Durrant <paul@xen.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-block@nongnu.org, Stefan Berger <stefanb@linux.vnet.ibm.com>,
David Hildenbrand <david@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Anthony Perard <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
Artyom Tarasenko <atar4qemu@gmail.com>,
Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Kevin Wolf <kwolf@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 4/7] qom: Replace void* parameter with Property* on field getters/setters
Date: Mon, 9 Nov 2020 11:44:55 +0100 [thread overview]
Message-ID: <20201109114455.2eb0fabd.cohuck@redhat.com> (raw)
In-Reply-To: <20201104172512.2381656-5-ehabkost@redhat.com>
On Wed, 4 Nov 2020 12:25:09 -0500
Eduardo Habkost <ehabkost@redhat.com> wrote:
> All field property getters and setters must interpret the fourth
> argument as Property*. Change the function signature of field
> property getters and setters to indicate that.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Paul Durrant <paul@xen.org>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Matthew Rosato <mjrosato@linux.ibm.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Cc: Artyom Tarasenko <atar4qemu@gmail.com>
> Cc: qemu-devel@nongnu.org
> Cc: xen-devel@lists.xenproject.org
> Cc: qemu-block@nongnu.org
> Cc: qemu-s390x@nongnu.org
> ---
> include/qom/field-property-internal.h | 8 +-
> include/qom/field-property.h | 26 ++++---
> backends/tpm/tpm_util.c | 11 ++-
> hw/block/xen-block.c | 6 +-
> hw/core/qdev-properties-system.c | 86 +++++++++-------------
> hw/s390x/css.c | 6 +-
> hw/s390x/s390-pci-bus.c | 6 +-
> hw/vfio/pci-quirks.c | 10 +--
> qom/property-types.c | 102 +++++++++-----------------
> target/sparc/cpu.c | 4 +-
> 10 files changed, 105 insertions(+), 160 deletions(-)
Acked-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-11-09 10:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 17:25 [PATCH 0/7] qom: Field properties type safety Eduardo Habkost
2020-11-04 17:25 ` [PATCH 1/7] sparc: Fix property/field size mismatch for iu-version Eduardo Habkost
2020-11-10 13:00 ` Mark Cave-Ayland
2020-11-04 17:25 ` [PATCH 2/7] qom: Save size of struct field in Property struct Eduardo Habkost
2020-11-04 17:25 ` [PATCH 3/7] qdev: Don't register unreadable legacy properties Eduardo Habkost
2020-11-04 17:25 ` [PATCH 4/7] qom: Replace void* parameter with Property* on field getters/setters Eduardo Habkost
2020-11-09 10:44 ` Cornelia Huck [this message]
2020-11-04 17:25 ` [PATCH 5/7] qom: Replace void* parameter with Property* on PropertyInfo.release Eduardo Habkost
2020-11-04 17:25 ` [PATCH 6/7] qom: Add FIELD_PTR, a type-safe wrapper for object_field_prop_ptr() Eduardo Habkost
2020-11-09 10:47 ` Cornelia Huck
2020-11-04 17:25 ` [PATCH 7/7] sparc: Use FIELD_PTR at nwindows getter/setter Eduardo Habkost
2020-11-10 13:04 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109114455.2eb0fabd.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=atar4qemu@gmail.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mjrosato@linux.ibm.com \
--cc=mreitz@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).